[commit] [avr] remove avr_push_dummy_code method.

[commit] [avr] remove avr_push_dummy_code method.

[Theodore A. Roth]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 387 bytes --]

Hi,

Committed the attached.

This removes the avr_push_dummy_code function. It doesn't seem to be
needed and what I committed last night didn't return anything which
broke the -Werror build. :-(

Ted Roth

2003-06-19  Theodore A. Roth  <troth@openavr.org>

        * avr-tdep.c (avr_push_dummy_code): Delete function.
        (avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code.

[-- Attachment #2: Type: TEXT/PLAIN, Size: 1534 bytes --]

2003-06-19  Theodore A. Roth  <troth@openavr.org>

	* avr-tdep.c (avr_push_dummy_code): Delete function.
	(avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code.

Index: avr-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/avr-tdep.c,v
retrieving revision 1.61
diff -u -p -r1.61 avr-tdep.c
--- avr-tdep.c	19 Jun 2003 08:09:54 -0000	1.61
+++ avr-tdep.c	19 Jun 2003 19:22:10 -0000
@@ -1128,16 +1128,6 @@ avr_unwind_dummy_id (struct gdbarch *gdb
   return frame_id_build (avr_make_saddr (base), frame_pc_unwind (next_frame));
 }
 
-static CORE_ADDR
-avr_push_dummy_code (struct gdbarch *gdbarch,
-                     CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc,
-                     struct value **args, int nargs,
-                     struct type *value_type,
-                     CORE_ADDR *real_pc, CORE_ADDR *bp_addr)
-{
-  fprintf_unfiltered (gdb_stderr, " ----->>>>  push_dummy_code\n");
-}
-
 /* When arguments must be pushed onto the stack, they go on in reverse
    order.  The below implements a FILO (stack) to do this. */
 
@@ -1357,7 +1347,6 @@ avr_gdbarch_init (struct gdbarch_info in
 
   set_gdbarch_call_dummy_address (gdbarch, avr_call_dummy_address);
   set_gdbarch_push_dummy_call (gdbarch, avr_push_dummy_call);
-  set_gdbarch_push_dummy_code (gdbarch, avr_push_dummy_code);
 
   set_gdbarch_address_to_pointer (gdbarch, avr_address_to_pointer);
   set_gdbarch_pointer_to_address (gdbarch, avr_pointer_to_address);

Re: [commit] [avr] remove avr_push_dummy_code method.

[Andrew Cagney]

> Hi,
> 
> Committed the attached.
> 
> This removes the avr_push_dummy_code function. It doesn't seem to be
> needed and what I committed last night didn't return anything which
> broke the -Werror build. :-(

Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK, 
and even then, the default (just write a breakpoint onto the stack) 
should be sufficient.

Unless AVR has something approaching the SPARC ABI that is....  (See the 
quote from Peter Schauer in sparc-tdep.c).

Andrew


> 2003-06-19  Theodore A. Roth  <troth@openavr.org>
> 
>         * avr-tdep.c (avr_push_dummy_code): Delete function.
>         (avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code.
> 
> 
> 
> 2003-06-19  Theodore A. Roth  <troth@openavr.org>
> 
> 	* avr-tdep.c (avr_push_dummy_code): Delete function.
> 	(avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code.
> 
> Index: avr-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/avr-tdep.c,v
> retrieving revision 1.61
> diff -u -p -r1.61 avr-tdep.c
> --- avr-tdep.c	19 Jun 2003 08:09:54 -0000	1.61
> +++ avr-tdep.c	19 Jun 2003 19:22:10 -0000
> @@ -1128,16 +1128,6 @@ avr_unwind_dummy_id (struct gdbarch *gdb
>    return frame_id_build (avr_make_saddr (base), frame_pc_unwind (next_frame));
>  }
>  
> -static CORE_ADDR
> -avr_push_dummy_code (struct gdbarch *gdbarch,
> -                     CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc,
> -                     struct value **args, int nargs,
> -                     struct type *value_type,
> -                     CORE_ADDR *real_pc, CORE_ADDR *bp_addr)
> -{
> -  fprintf_unfiltered (gdb_stderr, " ----->>>>  push_dummy_code\n");
> -}
> -
>  /* When arguments must be pushed onto the stack, they go on in reverse
>     order.  The below implements a FILO (stack) to do this. */
>  
> @@ -1357,7 +1347,6 @@ avr_gdbarch_init (struct gdbarch_info in
>  
>    set_gdbarch_call_dummy_address (gdbarch, avr_call_dummy_address);
>    set_gdbarch_push_dummy_call (gdbarch, avr_push_dummy_call);
> -  set_gdbarch_push_dummy_code (gdbarch, avr_push_dummy_code);
>  
>    set_gdbarch_address_to_pointer (gdbarch, avr_address_to_pointer);
>    set_gdbarch_pointer_to_address (gdbarch, avr_pointer_to_address);

Re: [commit] [avr] remove avr_push_dummy_code method.

[Theodore A. Roth]

On Thu, 19 Jun 2003, Andrew Cagney wrote:

> > Hi,
> >
> > Committed the attached.
> >
> > This removes the avr_push_dummy_code function. It doesn't seem to be
> > needed and what I committed last night didn't return anything which
> > broke the -Werror build. :-(
>
> Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK,
> and even then, the default (just write a breakpoint onto the stack)
> should be sufficient.
>
> Unless AVR has something approaching the SPARC ABI that is....  (See the
> quote from Peter Schauer in sparc-tdep.c).

Thanks. That gives me more confidence that I really don't need that
funciton. I had looked at the code where CALL_DUMMY_LOCATION ==
ON_STACK and it looked like generic_push_dummy_code() was sufficient.

Ted Roth