From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27185 invoked by alias); 19 Jun 2003 20:15:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26177 invoked from network); 19 Jun 2003 19:56:38 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 19 Jun 2003 19:56:38 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 800192B5F; Thu, 19 Jun 2003 15:56:36 -0400 (EDT) Message-ID: <3EF21574.1060508@redhat.com> Date: Thu, 19 Jun 2003 20:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Theodore A. Roth" Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] [avr] remove avr_push_dummy_code method. References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00637.txt.bz2 > Hi, > > Committed the attached. > > This removes the avr_push_dummy_code function. It doesn't seem to be > needed and what I committed last night didn't return anything which > broke the -Werror build. :-( Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK, and even then, the default (just write a breakpoint onto the stack) should be sufficient. Unless AVR has something approaching the SPARC ABI that is.... (See the quote from Peter Schauer in sparc-tdep.c). Andrew > 2003-06-19 Theodore A. Roth > > * avr-tdep.c (avr_push_dummy_code): Delete function. > (avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code. > > > > 2003-06-19 Theodore A. Roth > > * avr-tdep.c (avr_push_dummy_code): Delete function. > (avr_gdbarch_init): Don't call set_gdbarch_push_dummy_code. > > Index: avr-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/avr-tdep.c,v > retrieving revision 1.61 > diff -u -p -r1.61 avr-tdep.c > --- avr-tdep.c 19 Jun 2003 08:09:54 -0000 1.61 > +++ avr-tdep.c 19 Jun 2003 19:22:10 -0000 > @@ -1128,16 +1128,6 @@ avr_unwind_dummy_id (struct gdbarch *gdb > return frame_id_build (avr_make_saddr (base), frame_pc_unwind (next_frame)); > } > > -static CORE_ADDR > -avr_push_dummy_code (struct gdbarch *gdbarch, > - CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc, > - struct value **args, int nargs, > - struct type *value_type, > - CORE_ADDR *real_pc, CORE_ADDR *bp_addr) > -{ > - fprintf_unfiltered (gdb_stderr, " ----->>>> push_dummy_code\n"); > -} > - > /* When arguments must be pushed onto the stack, they go on in reverse > order. The below implements a FILO (stack) to do this. */ > > @@ -1357,7 +1347,6 @@ avr_gdbarch_init (struct gdbarch_info in > > set_gdbarch_call_dummy_address (gdbarch, avr_call_dummy_address); > set_gdbarch_push_dummy_call (gdbarch, avr_push_dummy_call); > - set_gdbarch_push_dummy_code (gdbarch, avr_push_dummy_code); > > set_gdbarch_address_to_pointer (gdbarch, avr_address_to_pointer); > set_gdbarch_pointer_to_address (gdbarch, avr_pointer_to_address);