From: "Theodore A. Roth" <troth@openavr.org>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] [avr] remove avr_push_dummy_code method.
Date: Thu, 19 Jun 2003 20:21:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.53.0306191307300.13978@knuth.amplepower.com> (raw)
In-Reply-To: <3EF21574.1060508@redhat.com>
On Thu, 19 Jun 2003, Andrew Cagney wrote:
> > Hi,
> >
> > Committed the attached.
> >
> > This removes the avr_push_dummy_code function. It doesn't seem to be
> > needed and what I committed last night didn't return anything which
> > broke the -Werror build. :-(
>
> Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK,
> and even then, the default (just write a breakpoint onto the stack)
> should be sufficient.
>
> Unless AVR has something approaching the SPARC ABI that is.... (See the
> quote from Peter Schauer in sparc-tdep.c).
Thanks. That gives me more confidence that I really don't need that
funciton. I had looked at the code where CALL_DUMMY_LOCATION ==
ON_STACK and it looked like generic_push_dummy_code() was sufficient.
Ted Roth
prev parent reply other threads:[~2003-06-19 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 19:32 Theodore A. Roth
2003-06-19 20:15 ` Andrew Cagney
2003-06-19 20:21 ` Theodore A. Roth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0306191307300.13978@knuth.amplepower.com \
--to=troth@openavr.org \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox