From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10796 invoked by alias); 19 Jun 2003 20:21:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32338 invoked from network); 19 Jun 2003 20:17:25 -0000 Received: from unknown (HELO planck.amplepower.com) (216.39.162.139) by sources.redhat.com with SMTP; 19 Jun 2003 20:17:25 -0000 Received: from [192.168.8.30] (helo=knuth.amplepower.com ident=roth) by planck.amplepower.com with esmtp (Exim 3.36 #1 (Debian)) id 19T5ec-00071g-00; Thu, 19 Jun 2003 13:05:06 -0700 Date: Thu, 19 Jun 2003 20:21:00 -0000 From: "Theodore A. Roth" X-X-Sender: roth@knuth.amplepower.com To: Andrew Cagney cc: gdb-patches@sources.redhat.com Subject: Re: [commit] [avr] remove avr_push_dummy_code method. In-Reply-To: <3EF21574.1060508@redhat.com> Message-ID: References: <3EF21574.1060508@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2003-06/txt/msg00638.txt.bz2 On Thu, 19 Jun 2003, Andrew Cagney wrote: > > Hi, > > > > Committed the attached. > > > > This removes the avr_push_dummy_code function. It doesn't seem to be > > needed and what I committed last night didn't return anything which > > broke the -Werror build. :-( > > Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK, > and even then, the default (just write a breakpoint onto the stack) > should be sufficient. > > Unless AVR has something approaching the SPARC ABI that is.... (See the > quote from Peter Schauer in sparc-tdep.c). Thanks. That gives me more confidence that I really don't need that funciton. I had looked at the code where CALL_DUMMY_LOCATION == ON_STACK and it looked like generic_push_dummy_code() was sufficient. Ted Roth