Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI

[Daniel Berlin <dan@dberlin.org>]

On Tue, 26 Mar 2002, Andrew Cagney wrote:
> You wrote:
> 

> > 
> > Whoops.
> > You're right.
> > I must have merged it while on crack or something.
> > I *meant* to add the frame argument, and only require *either* the 
> > context argument (Which is what it currently takes, a CFA context)  or the 
> > frame, but it looks like I messed up.
> > 
> > What it *should* look like is closer to the one from the WIP i sent. It 
> > should call get_saved_register with the frame argument if the context is 
> > null, or get_reg with the context argument if the context is not null.
> 
> That is what I was asking
> 
> I wrote:
> 
> >> Shouldn't the dwarf2 location expression evaluator be separated out 
> >> (dwarf2loc?) and be parameterized with both the frame it is to operate 
> >> within and the expression it is to evaluate. 

> > 
> > Whoops.
> > You're right.
> > I must have merged it while on crack or something.
> > I *meant* to add the frame argument, and only require *either* the 
> > context argument (Which is what it currently takes, a CFA context)  or the 
> > frame, but it looks like I messed up.
> > 
> > What it *should* look like is closer to the one from the WIP i sent. It 
> > should call get_saved_register with the frame argument if the context is 
> > null, or get_reg with the context argument if the context is not null.
> 
> That is what I was asking
> 
> I wrote:
> 
> >> Shouldn't the dwarf2 location expression evaluator be separated out 
> >> (dwarf2loc?) and be parameterized with both the frame it is to operate 
> >> within and the expression it is to evaluate. 
> 

> > 
> > Whoops.
> > You're right.
> > I must have merged it while on crack or something.
> > I *meant* to add the frame argument, and only require *either* the 
> > context argument (Which is what it currently takes, a CFA context)  or the 
> > frame, but it looks like I messed up.
> > 
> > What it *should* look like is closer to the one from the WIP i sent. It 
> > should call get_saved_register with the frame argument if the context is 
> > null, or get_reg with the context argument if the context is not null.
> 
> That is what I was asking

Errr, not really.
What I said is correct.
It is parameterized already with a frame and an expression.
It's just that we want to hand it a different type of frame.

You implied it wasn't parameterized with either, when it has been since 
the beginning.  However, I *meant* to change it to take either a struct 
context (one type of frame), or a struct frame_info. 
I've written this code so many times that I rewrote/merged it without 
thinking, and forgot to add the other type of frame parameter to the 
external entry point.

The only actual changes needed between what I submitted, and what it 
should be, is one more parameter, and changing read_register_gen to 
get_saved_register.

> I wrote:
> 
> >> Shouldn't the dwarf2 location expression evaluator be separated out 
> >> (dwarf2loc?) and be parameterized with both the frame it is to operate 
> >> within and the expression it is to evaluate. 
> 

> 
> > Yeah, so?
> > I'm doing this incrementally.
> > The first step is adding an external entry point, then moving it outside 
> > of dwarf2cfi.c, then modifying it to take a struct frame info, etc.
> > I'm trying to do this without breaking anything.
> > It currently *is* parameterized with both the frame and expression.  The 
> > problem is that the frame it expects isn't a "struct frame_info", it's a 
> > dwarf2 frame context.
> 
> Andrew
>