Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI

[Daniel Berlin <dan@dberlin.org>]

On Tue, 26 Mar 2002, Andrew Cagney wrote:

> > On Mon, 25 Mar 2002, Andrew Cagney wrote:
> > 
> > 
> >> > This patch simply adds an external entry point (dwarf2_execute_stack_op), 
> >> > that doesn't require the CFA context. It also adds code so that when the 
> >> > context passed to execute_stack_op is NULL, we use read_register_gen to 
> >> > get registers.
> > 
> >> 
> >> Hmm, where are you going here?
> > 
> > 
> > Um, rather than have multiple dwarf2 stack op executors, have one.
> > In order to do this, it needs to not require CFA context to be able to 
> > read registers.  
> 
> Shouldn't the dwarf2 location expression evaluator be separated out 
> (dwarf2loc?) and be parameterized with both the frame it is to operate 
> within and the expression it is to evaluate. 

Yeah, so?
I'm doing this incrementally.
The first step is adding an external entry point, then moving it outside 
of dwarf2cfi.c, then modifying it to take a struct frame info, etc.
I'm trying to do this without breaking anything.
It currently *is* parameterized with both the frame and expression.  The 
problem is that the frame it expects isn't a "struct frame_info", it's a 
dwarf2 frame context.

> If the expression 
> evaluator needs the value of a register from the frame it just calls 
> whatever the frame-get-reg-value(frame) function is.
> 
> Andrew
> 
>