From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: jjohnstn@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Watchpoints per thread patch
Date: Fri, 05 Nov 2004 11:49:00 -0000 [thread overview]
Message-ID: <OFFF2D534A.8B39E5E5-ON41256F43.00403951-41256F43.0040E5B4@de.ibm.com> (raw)
Jeff Johnston wrote:
> (s390_remove_one_watchpoint): New function.
> (s390_remove_watchpoint_callback): Ditto.
> (s390_remove_watchpoint): Change to iterate through lwps and
> remove the specified watchpoint for each thread.
> (s390_insert_one_watchpoint): New function.
> (s390_insert_watchpoint_callback): Ditto.
> (s390_insert_watchpoint): Change to iterate through lwps and
> insert the specified watchpoint on each thread.
Note that s390_insert/remove_watchpoint simply manipulate a global
data structure holding current watch points; only the routine
s390_fix_watch_points actually changes per-thread kernel state.
So it would appear simpler to only call s390_fix_watch_points
in a per-thread loop, and leave the higher-level functions alone.
(When a new thread attaches, you only need to run s390_fix_watch_points
on the new thread as well.)
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
--
Dr. Ulrich Weigand
Linux for S/390 Design & Development
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com
next reply other threads:[~2004-11-05 11:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 11:49 Ulrich Weigand [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-19 23:57 Jeff Johnston
2004-10-20 5:04 ` Eli Zaretskii
2004-10-20 11:03 ` Mark Kettenis
2004-10-20 16:21 ` Jeff Johnston
2004-10-20 17:27 ` Andrew Cagney
2004-10-20 17:30 ` Daniel Jacobowitz
2004-10-27 22:36 ` Jeff Johnston
2004-10-27 22:41 ` Daniel Jacobowitz
2004-10-27 23:17 ` Jeff Johnston
2004-10-28 13:33 ` Daniel Jacobowitz
2004-10-28 19:47 ` Jeff Johnston
2004-10-28 19:52 ` Daniel Jacobowitz
2004-10-28 20:13 ` Jeff Johnston
2004-10-28 4:55 ` Eli Zaretskii
2004-11-04 18:25 ` Jeff Johnston
2004-11-04 21:21 ` Eli Zaretskii
2004-11-05 4:49 ` Daniel Jacobowitz
2004-11-05 16:52 ` Andrew Cagney
2004-11-05 18:29 ` Daniel Jacobowitz
2004-11-08 21:33 ` Andrew Cagney
2004-11-09 1:04 ` Daniel Jacobowitz
2004-11-09 2:20 ` Andrew Cagney
2004-11-09 2:33 ` Daniel Jacobowitz
2004-11-09 4:53 ` Eli Zaretskii
2004-11-09 15:11 ` Andrew Cagney
2004-11-09 18:41 ` Daniel Jacobowitz
2004-11-11 21:22 ` Andrew Cagney
2004-11-09 19:06 ` Jeff Johnston
2004-11-09 19:31 ` Daniel Jacobowitz
2004-11-09 20:24 ` Jim Blandy
2004-11-10 0:02 ` Jeff Johnston
2004-11-10 14:39 ` Jim Blandy
2004-11-11 21:23 ` Andrew Cagney
2004-11-09 20:48 ` Jeff Johnston
2004-11-09 20:50 ` Daniel Jacobowitz
2004-11-10 19:45 ` Eli Zaretskii
2004-11-10 22:08 ` Jeff Johnston
2004-11-10 19:43 ` Eli Zaretskii
2004-10-20 19:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFFF2D534A.8B39E5E5-ON41256F43.00403951-41256F43.0040E5B4@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox