From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2813 invoked by alias); 5 Nov 2004 11:49:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2804 invoked from network); 5 Nov 2004 11:49:22 -0000 Received: from unknown (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org with SMTP; 5 Nov 2004 11:49:22 -0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.12.10/8.12.10) with ESMTP id iA5BnExD192364; Fri, 5 Nov 2004 11:49:14 GMT Received: from d12ml068.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id iA5BnD9P083746; Fri, 5 Nov 2004 12:49:13 +0100 Subject: Re: [RFA]: Watchpoints per thread patch To: jjohnstn@redhat.com Cc: gdb-patches@sources.redhat.com Message-ID: From: Ulrich Weigand Date: Fri, 05 Nov 2004 11:49:00 -0000 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII X-SW-Source: 2004-11/txt/msg00075.txt.bz2 Jeff Johnston wrote: > (s390_remove_one_watchpoint): New function. > (s390_remove_watchpoint_callback): Ditto. > (s390_remove_watchpoint): Change to iterate through lwps and > remove the specified watchpoint for each thread. > (s390_insert_one_watchpoint): New function. > (s390_insert_watchpoint_callback): Ditto. > (s390_insert_watchpoint): Change to iterate through lwps and > insert the specified watchpoint on each thread. Note that s390_insert/remove_watchpoint simply manipulate a global data structure holding current watch points; only the routine s390_fix_watch_points actually changes per-thread kernel state. So it would appear simpler to only call s390_fix_watch_points in a per-thread loop, and leave the higher-level functions alone. (When a new thread attaches, you only need to run s390_fix_watch_points on the new thread as well.) Mit freundlichen Gruessen / Best Regards Ulrich Weigand -- Dr. Ulrich Weigand Linux for S/390 Design & Development IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com