AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW

["Michael Fischer" <fischermi@t-online.de>]

I have make a quick test and added:

#undef DIRNAME_SEPARATOR
#define DIRNAME_SEPARATOR ';'

after all includes in source.c

This is working now!

I think we should change defs.h from:

#ifdef __MSDOS__
# define CANT_FORK
# define GLOBAL_CURDIR
# define DIRNAME_SEPARATOR ';'
#endif

#ifndef DIRNAME_SEPARATOR
#define DIRNAME_SEPARATOR ':'
#endif

to:

#ifdef __MSDOS__
#define CANT_FORK
#define GLOBAL_CURDIR
#endif

#if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined
(__CYGWIN__)
#define DIRNAME_SEPARATOR ';'
#endif

#ifndef DIRNAME_SEPARATOR
#define DIRNAME_SEPARATOR ':'
#endif


But I do not know if this will breaks the other one.
I saw this define construct will be used in filenames to.

Michael


-----Ursprungliche Nachricht-----
Von: gdb-patches-owner@sourceware.org
[mailto:gdb-patches-owner@sourceware.org]Im Auftrag von Masaki Muranaka
Gesendet: Sonntag, 18. Juni 2006 06:57
An: Eli Zaretskii
Cc: Michael Fischer; gdb-patches@sourceware.org
Betreff: Re: AW: [PATCH] source.s: Fix problem handling windows like
path with MinGW



On 2006/06/18, at 12:23, Eli Zaretskii wrote:

> [Please don't take this discussion off the mailing list.]
>
>> From: "Michael Fischer" <fischermi@t-online.de>
>> Date: Sat, 17 Jun 2006 23:32:25 +0200
>>
>> Why ":" and not ";" ?
>>
>> If I compile the GDB under MinGW, DIRNAME_SEPARATOR was set to ":".
>> If you take a look in gdb\defs.h, ";" is only defined in case of
>> __MSDOS__. I think MinGW will not set this define?!
>
> What happens if you modify defs.h to define DIRNAME_SEPARATOR as `;'?
> Does the problem go away?
>
>> I think in this case, we should change the add_path function too.
>
> I think if DIRNAME_SEPARATOR is `;', add_path will do what you need.
>
> Could you please check that?

BTW, Why do we use DIRNAME_SEPARATOR, instead of PATH_SEPARATOR ?
As PATH_SEPARATOR is detected by configure, it is trustable.

I think they will be same value on self builds, right?
Also we can choice to modify xm-.h on cross builds.

--
Masaki Muranaka
Monami software