Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW

[Daniel Jacobowitz <drow@false.org>]

On Mon, Jun 19, 2006 at 06:22:26AM +0300, Eli Zaretskii wrote:
> > Date: Sun, 18 Jun 2006 16:15:51 -0400
> > From: Christopher Faylor <me@cgf.cx>
> > 
> > Yes, that's right.  So, it should be:
> > 
> > #if defined(__MSDOS__) || (!defined (__CYGWIN__) && defined (_WIN32))
> 
> Agreed.
> 
> > I'm surprised that there isn't something like that already in place.
> 
> Me too.  Can someone who routinely builds MinGW ports (Daniel?) please
> comment?  How do you get GDB to DTRT without defining DIRNAME_SEPARATOR
> to be `;'?

I have no idea; presumably it doesn't.  We've got only limited test
coverage on our native Windows GDB (lack of expect makes everything
much harder).

Personally, I'd grab the #define from libiberty/make-relative-prefix.c,
and maybe even move it into include/filenames.h.  That one's better
tested.  But it uses ';' if _WIN32, so don't ask me how that works for
Cygwin builds.  Maybe it doesn't.

I'm fine with Chris's suggested definition, naturally.

-- 
Daniel Jacobowitz
CodeSourcery