From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5630 invoked by alias); 20 Jun 2006 20:27:48 -0000 Received: (qmail 5618 invoked by uid 22791); 20 Jun 2006 20:27:47 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 20 Jun 2006 20:27:45 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fsmp4-0000UT-SB; Tue, 20 Jun 2006 16:27:43 -0400 Date: Tue, 20 Jun 2006 20:27:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Michael Fischer , gdb-patches@sourceware.org Subject: Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW Message-ID: <20060620202742.GD1453@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , Michael Fischer , gdb-patches@sourceware.org References: <20060618201551.GA6038@trixie.casa.cgf.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00292.txt.bz2 On Mon, Jun 19, 2006 at 06:22:26AM +0300, Eli Zaretskii wrote: > > Date: Sun, 18 Jun 2006 16:15:51 -0400 > > From: Christopher Faylor > > > > Yes, that's right. So, it should be: > > > > #if defined(__MSDOS__) || (!defined (__CYGWIN__) && defined (_WIN32)) > > Agreed. > > > I'm surprised that there isn't something like that already in place. > > Me too. Can someone who routinely builds MinGW ports (Daniel?) please > comment? How do you get GDB to DTRT without defining DIRNAME_SEPARATOR > to be `;'? I have no idea; presumably it doesn't. We've got only limited test coverage on our native Windows GDB (lack of expect makes everything much harder). Personally, I'd grab the #define from libiberty/make-relative-prefix.c, and maybe even move it into include/filenames.h. That one's better tested. But it uses ';' if _WIN32, so don't ask me how that works for Cygwin builds. Maybe it doesn't. I'm fine with Chris's suggested definition, naturally. -- Daniel Jacobowitz CodeSourcery