Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW

[Christopher Faylor <me@cgf.cx>]

On Sun, Jun 18, 2006 at 10:05:30PM +0200, Michael Fischer wrote:
>>> #ifdef __MSDOS__
>>> #define CANT_FORK
>>> #define GLOBAL_CURDIR
>>> #endif
>>>
>>> #if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined
>>> (__CYGWIN__)
>>> #define DIRNAME_SEPARATOR ';'
>>> #endif
>>
>>I think __CYGWIN__ should not be here.  In fact, even _WIN32 should
>>not trigger use of `;' unless __CYGWIN__ is not defined.  Chris, is
>>that right?
>>
>>Does anyone object to adding something like the above, provided that
>>we are careful not to break Cygwin?
>
>To make sure that we does not break Cygwin, perhaps we can use the following
>check:
>
>#if defined(__MSDOS__) || defined (__MINGW32__)
>#define DIRNAME_SEPARATOR ';'
>#endif
>
>Only check for __MSDOS__ and __MINGW32__ in this case Cygwin
>could not be affected.

I think you might as well check for _WIN32 directly since there's no need to
put a barrier in the code to using a Microsoft compiler at some point.

cgf