Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW

[Christopher Faylor <me@cgf.cx>]

On Sun, Jun 18, 2006 at 10:46:55PM +0300, Eli Zaretskii wrote:
>> From: "Michael Fischer" <fischermi@t-online.de>
>> Date: Sun, 18 Jun 2006 11:03:43 +0200
>> 
>> I have make a quick test and added:
>> 
>> #undef DIRNAME_SEPARATOR
>> #define DIRNAME_SEPARATOR ';'
>> 
>> after all includes in source.c
>> 
>> This is working now!
>
>Thank you for testing.
>
>> #ifdef __MSDOS__
>> #define CANT_FORK
>> #define GLOBAL_CURDIR
>> #endif
>> 
>> #if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined
>> (__CYGWIN__)
>> #define DIRNAME_SEPARATOR ';'
>> #endif
>
>I think __CYGWIN__ should not be here.  In fact, even _WIN32 should
>not trigger use of `;' unless __CYGWIN__ is not defined.  Chris, is
>that right?
>
>Does anyone object to adding something like the above, provided that
>we are careful not to break Cygwin?

Yes, that's right.  So, it should be:

#if defined(__MSDOS__) || (!defined (__CYGWIN__) && defined (_WIN32))

No objections from me on adding this.  I'm surprised that there isn't
something like that already in place.

cgf