From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44624-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18675 invoked by alias); 18 Jun 2006 20:15:56 -0000
Received: (qmail 18667 invoked by uid 22791); 18 Jun 2006 20:15:55 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-71-248-179-97.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.97)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 20:15:53 +0000
Received: by cgf.cx (Postfix, from userid 201) 	id B97D413C01F; Sun, 18 Jun 2006 16:15:51 -0400 (EDT)
Date: Sun, 18 Jun 2006 20:15:00 -0000
From: Christopher Faylor <me@cgf.cx>
To: Michael Fischer <fischermi@t-online.de>, gdb-patches@sourceware.org
Subject: Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW
Message-ID: <20060618201551.GA6038@trixie.casa.cgf.cx>
Mail-Followup-To: Michael Fischer <fischermi@t-online.de>, 	gdb-patches@sourceware.org
References: <JLEAKDMELBINENLADICFAEFKCIAA.fischermi@t-online.de> <umzca2qmo.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <umzca2qmo.fsf@gnu.org>
User-Agent: Mutt/1.5.11
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00261.txt.bz2

On Sun, Jun 18, 2006 at 10:46:55PM +0300, Eli Zaretskii wrote:
>> From: "Michael Fischer" <fischermi@t-online.de>
>> Date: Sun, 18 Jun 2006 11:03:43 +0200
>> 
>> I have make a quick test and added:
>> 
>> #undef DIRNAME_SEPARATOR
>> #define DIRNAME_SEPARATOR ';'
>> 
>> after all includes in source.c
>> 
>> This is working now!
>
>Thank you for testing.
>
>> #ifdef __MSDOS__
>> #define CANT_FORK
>> #define GLOBAL_CURDIR
>> #endif
>> 
>> #if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined
>> (__CYGWIN__)
>> #define DIRNAME_SEPARATOR ';'
>> #endif
>
>I think __CYGWIN__ should not be here.  In fact, even _WIN32 should
>not trigger use of `;' unless __CYGWIN__ is not defined.  Chris, is
>that right?
>
>Does anyone object to adding something like the above, provided that
>we are careful not to break Cygwin?

Yes, that's right.  So, it should be:

#if defined(__MSDOS__) || (!defined (__CYGWIN__) && defined (_WIN32))

No objections from me on adding this.  I'm surprised that there isn't
something like that already in place.

cgf