From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44625-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19130 invoked by alias); 18 Jun 2006 20:16:36 -0000
Received: (qmail 19122 invoked by uid 22791); 18 Jun 2006 20:16:36 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-71-248-179-97.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.97)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 20:16:34 +0000
Received: by cgf.cx (Postfix, from userid 201) 	id 2F12713C01F; Sun, 18 Jun 2006 16:16:33 -0400 (EDT)
Date: Sun, 18 Jun 2006 20:16:00 -0000
From: Christopher Faylor <me@cgf.cx>
To: gdb-patches@sourceware.org, Michael Fischer <fischermi@t-online.de>
Subject: Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW
Message-ID: <20060618201632.GB6038@trixie.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org, 	Michael Fischer <fischermi@t-online.de>
References: <umzca2qmo.fsf@gnu.org> <JLEAKDMELBINENLADICFEEFNCIAA.fischermi@t-online.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <JLEAKDMELBINENLADICFEEFNCIAA.fischermi@t-online.de>
User-Agent: Mutt/1.5.11
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00262.txt.bz2

On Sun, Jun 18, 2006 at 10:05:30PM +0200, Michael Fischer wrote:
>>> #ifdef __MSDOS__
>>> #define CANT_FORK
>>> #define GLOBAL_CURDIR
>>> #endif
>>>
>>> #if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined
>>> (__CYGWIN__)
>>> #define DIRNAME_SEPARATOR ';'
>>> #endif
>>
>>I think __CYGWIN__ should not be here.  In fact, even _WIN32 should
>>not trigger use of `;' unless __CYGWIN__ is not defined.  Chris, is
>>that right?
>>
>>Does anyone object to adding something like the above, provided that
>>we are careful not to break Cygwin?
>
>To make sure that we does not break Cygwin, perhaps we can use the following
>check:
>
>#if defined(__MSDOS__) || defined (__MINGW32__)
>#define DIRNAME_SEPARATOR ';'
>#endif
>
>Only check for __MSDOS__ and __MINGW32__ in this case Cygwin
>could not be affected.

I think you might as well check for _WIN32 directly since there's no need to
put a barrier in the code to using a Microsoft compiler at some point.

cgf