From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29309 invoked by alias); 18 Jun 2006 09:03:37 -0000 Received: (qmail 29301 invoked by uid 22791); 18 Jun 2006 09:03:36 -0000 X-Spam-Check-By: sourceware.org Received: from mailout09.sul.t-online.com (HELO mailout09.sul.t-online.com) (194.25.134.84) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 09:03:33 +0000 Received: from fwd32.aul.t-online.de by mailout09.sul.t-online.com with smtp id 1FrtBq-0001la-04; Sun, 18 Jun 2006 11:03:30 +0200 Received: from merlin (JO2Fd+Z6geWeNxVcctzde99DVsfW9dDXg66oY7YQfuWxASa2+GflUL@[84.138.96.155]) by fwd32.sul.t-online.de with esmtp id 1FrtBd-0xawAS0; Sun, 18 Jun 2006 11:03:17 +0200 From: "Michael Fischer" To: Subject: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW Date: Sun, 18 Jun 2006 09:03:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <735259CC-31B1-4B61-A586-AF0B642CA374@monami-software.com> X-ID: JO2Fd+Z6geWeNxVcctzde99DVsfW9dDXg66oY7YQfuWxASa2+GflUL X-TOI-MSGID: ef7d17f6-f82a-4288-b6c2-72f945ca0258 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00257.txt.bz2 I have make a quick test and added: #undef DIRNAME_SEPARATOR #define DIRNAME_SEPARATOR ';' after all includes in source.c This is working now! I think we should change defs.h from: #ifdef __MSDOS__ # define CANT_FORK # define GLOBAL_CURDIR # define DIRNAME_SEPARATOR ';' #endif #ifndef DIRNAME_SEPARATOR #define DIRNAME_SEPARATOR ':' #endif to: #ifdef __MSDOS__ #define CANT_FORK #define GLOBAL_CURDIR #endif #if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) || defined (__CYGWIN__) #define DIRNAME_SEPARATOR ';' #endif #ifndef DIRNAME_SEPARATOR #define DIRNAME_SEPARATOR ':' #endif But I do not know if this will breaks the other one. I saw this define construct will be used in filenames to. Michael -----Ursprungliche Nachricht----- Von: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org]Im Auftrag von Masaki Muranaka Gesendet: Sonntag, 18. Juni 2006 06:57 An: Eli Zaretskii Cc: Michael Fischer; gdb-patches@sourceware.org Betreff: Re: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW On 2006/06/18, at 12:23, Eli Zaretskii wrote: > [Please don't take this discussion off the mailing list.] > >> From: "Michael Fischer" >> Date: Sat, 17 Jun 2006 23:32:25 +0200 >> >> Why ":" and not ";" ? >> >> If I compile the GDB under MinGW, DIRNAME_SEPARATOR was set to ":". >> If you take a look in gdb\defs.h, ";" is only defined in case of >> __MSDOS__. I think MinGW will not set this define?! > > What happens if you modify defs.h to define DIRNAME_SEPARATOR as `;'? > Does the problem go away? > >> I think in this case, we should change the add_path function too. > > I think if DIRNAME_SEPARATOR is `;', add_path will do what you need. > > Could you please check that? BTW, Why do we use DIRNAME_SEPARATOR, instead of PATH_SEPARATOR ? As PATH_SEPARATOR is detected by configure, it is trustable. I think they will be same value on self builds, right? Also we can choice to modify xm-.h on cross builds. -- Masaki Muranaka Monami software