PATCH: PR tui/14486: resize crashes tui

PATCH: PR tui/14486: resize crashes tui

[H.J. Lu]

This patch checks if TUI_SRC_WIN is not NULL before referencing it.  OK
to install?

Thanks.


H.J.
----
2010-08-17  H.J. Lu  <hongjiu.lu@intel.com>

	PR tui/14486
	* tui/tui-source.c (tui_source_is_displayed): Check if TUI_SRC_WIN
	is not NULL before referencing it.

diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index 9ba9b1d..030653c 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch, struct symtab *s,
 int
 tui_source_is_displayed (char *fname)
 {
-  return (TUI_SRC_WIN->generic.content_in_use 
+  return (TUI_SRC_WIN != NULL
+	  && TUI_SRC_WIN->generic.content_in_use 
 	  && (filename_cmp (((struct tui_win_element *)
 			     (tui_locator_win_info_ptr ())->
 			     content[0])->which_element.locator.file_name,

RE: PATCH: PR tui/14486: resize crashes tui

[Abid, Hafiz]

You may want to look at the following thread. It seems to be fixing a related problem.

http://sourceware.org/ml/gdb-patches/2012-08/msg00349.html


Regards,
Abid

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of H.J. Lu
> Sent: Friday, August 17, 2012 9:33 PM
> To: GDB
> Subject: PATCH: PR tui/14486: resize crashes tui
> 
> This patch checks if TUI_SRC_WIN is not NULL before referencing it.  OK
> to install?
> 
> Thanks.
> 
> 
> H.J.
> ----
> 2010-08-17  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR tui/14486
> 	* tui/tui-source.c (tui_source_is_displayed): Check if
> TUI_SRC_WIN
> 	is not NULL before referencing it.
> 
> diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
> index 9ba9b1d..030653c 100644
> --- a/gdb/tui/tui-source.c
> +++ b/gdb/tui/tui-source.c
> @@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch,
> struct symtab *s,
>  int
>  tui_source_is_displayed (char *fname)
>  {
> -  return (TUI_SRC_WIN->generic.content_in_use
> +  return (TUI_SRC_WIN != NULL
> +	  && TUI_SRC_WIN->generic.content_in_use
>  	  && (filename_cmp (((struct tui_win_element *)
>  			     (tui_locator_win_info_ptr ())->
>  			     content[0])->which_element.locator.file_name,

Re: PATCH: PR tui/14486: resize crashes tui

[H.J. Lu]

On Mon, Aug 20, 2012 at 3:36 AM, Abid, Hafiz <Hafiz_Abid@mentor.com> wrote:
> You may want to look at the following thread. It seems to be fixing a related problem.
>
> http://sourceware.org/ml/gdb-patches/2012-08/msg00349.html
>

I think it is the same problem.

> Regards,
> Abid
>
>> -----Original Message-----
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] On Behalf Of H.J. Lu
>> Sent: Friday, August 17, 2012 9:33 PM
>> To: GDB
>> Subject: PATCH: PR tui/14486: resize crashes tui
>>
>> This patch checks if TUI_SRC_WIN is not NULL before referencing it.  OK
>> to install?
>>
>> Thanks.
>>
>>
>> H.J.
>> ----
>> 2010-08-17  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>       PR tui/14486
>>       * tui/tui-source.c (tui_source_is_displayed): Check if
>> TUI_SRC_WIN
>>       is not NULL before referencing it.
>>
>> diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
>> index 9ba9b1d..030653c 100644
>> --- a/gdb/tui/tui-source.c
>> +++ b/gdb/tui/tui-source.c
>> @@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch,
>> struct symtab *s,
>>  int
>>  tui_source_is_displayed (char *fname)
>>  {
>> -  return (TUI_SRC_WIN->generic.content_in_use
>> +  return (TUI_SRC_WIN != NULL
>> +       && TUI_SRC_WIN->generic.content_in_use
>>         && (filename_cmp (((struct tui_win_element *)
>>                            (tui_locator_win_info_ptr ())->
>>                            content[0])->which_element.locator.file_name,



-- 
H.J.