From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23132 invoked by alias); 20 Aug 2012 10:36:52 -0000 Received: (qmail 23038 invoked by uid 22791); 20 Aug 2012 10:36:51 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Aug 2012 10:36:36 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T3PLW-0002w9-H9 from Hafiz_Abid@mentor.com ; Mon, 20 Aug 2012 03:36:34 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 20 Aug 2012 03:36:34 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.57]) by SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) with mapi id 14.01.0289.001; Mon, 20 Aug 2012 11:36:33 +0100 From: "Abid, Hafiz" To: "H.J. Lu" , GDB Subject: RE: PATCH: PR tui/14486: resize crashes tui Date: Mon, 20 Aug 2012 10:36:00 -0000 Message-ID: References: <20120817203303.GA16406@intel.com> In-Reply-To: <20120817203303.GA16406@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00537.txt.bz2 You may want to look at the following thread. It seems to be fixing a relat= ed problem. http://sourceware.org/ml/gdb-patches/2012-08/msg00349.html Regards, Abid > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of H.J. Lu > Sent: Friday, August 17, 2012 9:33 PM > To: GDB > Subject: PATCH: PR tui/14486: resize crashes tui >=20 > This patch checks if TUI_SRC_WIN is not NULL before referencing it. OK > to install? >=20 > Thanks. >=20 >=20 > H.J. > ---- > 2010-08-17 H.J. Lu >=20 > PR tui/14486 > * tui/tui-source.c (tui_source_is_displayed): Check if > TUI_SRC_WIN > is not NULL before referencing it. >=20 > diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c > index 9ba9b1d..030653c 100644 > --- a/gdb/tui/tui-source.c > +++ b/gdb/tui/tui-source.c > @@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch, > struct symtab *s, > int > tui_source_is_displayed (char *fname) > { > - return (TUI_SRC_WIN->generic.content_in_use > + return (TUI_SRC_WIN !=3D NULL > + && TUI_SRC_WIN->generic.content_in_use > && (filename_cmp (((struct tui_win_element *) > (tui_locator_win_info_ptr ())-> > content[0])->which_element.locator.file_name,