From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, GDB <gdb-patches@sourceware.org>
Subject: RE: PATCH: PR tui/14486: resize crashes tui
Date: Mon, 20 Aug 2012 10:36:00 -0000 [thread overview]
Message-ID: <EB3B29AD43CA924DA27099BC851923762A2E9C@EU-MBX-03.mgc.mentorg.com> (raw)
In-Reply-To: <20120817203303.GA16406@intel.com>
You may want to look at the following thread. It seems to be fixing a related problem.
http://sourceware.org/ml/gdb-patches/2012-08/msg00349.html
Regards,
Abid
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of H.J. Lu
> Sent: Friday, August 17, 2012 9:33 PM
> To: GDB
> Subject: PATCH: PR tui/14486: resize crashes tui
>
> This patch checks if TUI_SRC_WIN is not NULL before referencing it. OK
> to install?
>
> Thanks.
>
>
> H.J.
> ----
> 2010-08-17 H.J. Lu <hongjiu.lu@intel.com>
>
> PR tui/14486
> * tui/tui-source.c (tui_source_is_displayed): Check if
> TUI_SRC_WIN
> is not NULL before referencing it.
>
> diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
> index 9ba9b1d..030653c 100644
> --- a/gdb/tui/tui-source.c
> +++ b/gdb/tui/tui-source.c
> @@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch,
> struct symtab *s,
> int
> tui_source_is_displayed (char *fname)
> {
> - return (TUI_SRC_WIN->generic.content_in_use
> + return (TUI_SRC_WIN != NULL
> + && TUI_SRC_WIN->generic.content_in_use
> && (filename_cmp (((struct tui_win_element *)
> (tui_locator_win_info_ptr ())->
> content[0])->which_element.locator.file_name,
next prev parent reply other threads:[~2012-08-20 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:33 H.J. Lu
2012-08-20 10:36 ` Abid, Hafiz [this message]
2012-08-20 13:30 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB3B29AD43CA924DA27099BC851923762A2E9C@EU-MBX-03.mgc.mentorg.com \
--to=hafiz_abid@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox