From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27559 invoked by alias); 17 Aug 2012 20:33:17 -0000 Received: (qmail 27549 invoked by uid 22791); 17 Aug 2012 20:33:16 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Aug 2012 20:33:04 +0000 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 17 Aug 2012 13:33:03 -0700 X-ExtLoop1: 1 Received: from gnu-6.sc.intel.com ([10.3.194.135]) by AZSMGA002.ch.intel.com with ESMTP; 17 Aug 2012 13:33:03 -0700 Received: by gnu-6.sc.intel.com (Postfix, from userid 500) id 62B9C80CD2; Fri, 17 Aug 2012 13:33:03 -0700 (PDT) Date: Fri, 17 Aug 2012 20:33:00 -0000 From: "H.J. Lu" To: GDB Subject: PATCH: PR tui/14486: resize crashes tui Message-ID: <20120817203303.GA16406@intel.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00495.txt.bz2 This patch checks if TUI_SRC_WIN is not NULL before referencing it. OK to install? Thanks. H.J. ---- 2010-08-17 H.J. Lu PR tui/14486 * tui/tui-source.c (tui_source_is_displayed): Check if TUI_SRC_WIN is not NULL before referencing it. diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index 9ba9b1d..030653c 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -334,7 +334,8 @@ tui_show_symtab_source (struct gdbarch *gdbarch, struct symtab *s, int tui_source_is_displayed (char *fname) { - return (TUI_SRC_WIN->generic.content_in_use + return (TUI_SRC_WIN != NULL + && TUI_SRC_WIN->generic.content_in_use && (filename_cmp (((struct tui_win_element *) (tui_locator_win_info_ptr ())-> content[0])->which_element.locator.file_name,