Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 7/8] Documentation changes
Date: Tue, 08 Nov 2011 08:37:00 -0000	[thread overview]
Message-ID: <E1RNhAm-0008QB-Nq@fencepost.gnu.org> (raw)
In-Reply-To: <4EB8CF86.9080303@codesourcery.com> (message from Yao Qi on Tue,	08 Nov 2011 14:43:18 +0800)

> Date: Tue, 08 Nov 2011 14:43:18 +0800
> From: Yao Qi <yao@codesourcery.com>
> 
> This patch is about documentation changes to reflect 1) the changes on
> tracepoint behavior, 2) a new remote feature.

Thanks.  A few comments about this part:

>  data, and then allow the program to continue.  Setting a tracepoint or
> -changing its actions doesn't take effect until the next @code{tstart}
> +changing its actions takes effect immediately, which  depends on the
> +remote stub's support of @samp{InstallInTrace} feature

I think you meant something like this:

  Setting a tracepoint or changing its actions takes effect
  immediately if the remote stub supports the @samp{InstallInTrace}
  feature.

>                                                        (see
> +@ref{install tracepoint in tracing})for remote targets.

Please use @pxref here, which does TRT for a cross-reference in
parentheses; @ref doesn't (it needs a comma or a period after the
closing brace; makeinfo will bitch at you if you don't put one or the
other).

> +If remote stub doesn't support @samp{InstallInTrace} feature, all these
                                ^^
"the" is missing here.

Okay with these changes.


  reply	other threads:[~2011-11-08  8:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  6:00 [patch 0/8] Download tracepoint locations when tracing is running Yao Qi
2011-11-08  6:08 ` [patch 1/8] Download tracepoint on location level Yao Qi
2011-11-09  3:34   ` Yao Qi
2011-11-10 14:54     ` Pedro Alves
2011-11-08  6:12 ` [patch 2/8] New remote feature InstallInTrace Yao Qi
2011-11-10 15:03   ` Pedro Alves
2011-11-08  6:21 ` [patch 3/8] New target hook `to_can_download_tracepoint_loc' Yao Qi
2011-11-10 15:11   ` Pedro Alves
2011-11-08  6:30 ` [patch 4/8] Download tracepoint locations and track its status Yao Qi
2011-11-09  3:47   ` Yao Qi
2011-11-10 15:51     ` Pedro Alves
2011-11-12  2:11       ` Yao Qi
2011-11-14 12:24         ` Pedro Alves
2011-11-08  6:33 ` [patch 5/8] refactor gdbserver on installing fast tracepoint Yao Qi
2011-11-10 15:57   ` Pedro Alves
2011-11-08  6:40 ` [patch 6/8] gdbserver - Install tracepoint when tracing is running Yao Qi
2011-11-08  8:20   ` Eli Zaretskii
2011-11-08  8:41     ` Yao Qi
2011-11-08 11:38       ` Eli Zaretskii
2011-11-10 16:53   ` Pedro Alves
2011-11-12  2:40     ` Yao Qi
2011-11-14 12:32       ` Pedro Alves
2011-11-08  6:43 ` [patch 7/8] Documentation changes Yao Qi
2011-11-08  8:37   ` Eli Zaretskii [this message]
2011-11-10 17:02   ` Pedro Alves
2011-11-12  3:09     ` Yao Qi
2011-11-08  6:56 ` [patch 8/8] Test cases Yao Qi
2011-11-10 17:16   ` Pedro Alves
2011-11-10 18:28   ` Pedro Alves
2011-11-12  3:35     ` Yao Qi
2011-11-14 13:00       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1RNhAm-0008QB-Nq@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox