Re: [patch 8/8] Test cases

Pedro Alves
2011-11-10T18:28:57Z

On Tuesday 08 November 2011 06:55:26, Yao Qi wrote:
>
> These new test cases are to verify that tracepoint changed after
> `tstart' still work properly. There are two FAILs in change-loc.exp on
> x86_64-linux, but they are not related to this patch set. They are
> caused by an existing problem that jmp insn is incorrectly generated in
> jump pad if offset exceeds the limit of integer (32-bit). It could
> happen on x86_64 system.

We were meant to error out in these cases. Guess something's missing.

> +set testfile "change-loc"
> +set libfile1 "change-loc-1"
> +set libfile2 "change-loc-2"
> +set srcfile $testfile.c
> +set executable $testfile
> +set libsrc1 $srcdir/$subdir/$libfile1.c
> +set libsrc2 $srcdir/$subdir/$libfile2.c

Spurious spaces.

> +set binfile $objdir/$subdir/$testfile

> +set lib_sl1 $objdir/$subdir/$libfile1.sl
> +set lib_sl2 $objdir/$subdir/$libfile2.sl

Ditto.

> +
> +set lib_opts debug

Ditto.

Please make sure the new test messages are unique:

$ cat testsuite/gdb.sum | grep "PASS" | sort | uniq -c | sort -n | tail -n 15
1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstart
1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstop
1 PASS: gdb.trace/trace-break.exp: IPA loaded
2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@0: ftrace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@1: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace ftrace@1: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace trace@0: trace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace ftrace@0: ftrace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace trace@1: trace set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@0: trace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@1: trace set_point
2 PASS: gdb.trace/trace-break.exp: 6 ftrace disable ftrace enable: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 6 ftrace enable ftrace disable: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 6 trace disable trace enable: trace set_point
2 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: trace set_point

Otherwise okay.

--
Pedro Alves