Re: [patch 4/8] Download tracepoint locations and track its status

Pedro Alves
2011-11-14T12:24:41Z

On Saturday 12 November 2011 02:11:06, Yao Qi wrote:
> 0004-tracepoint-change-loc.patch
> * breakpoint.h (struct bp_location): Add comment on field
> `duplicate'.
> * breakpoint.c (should_be_inserted): Don't differentiate breakpoint
> and tracepoint.
> (remove_breakpoints): Don't remove tracepoints.
> (tracepoint_locations_match ): New.
> (breakpoint_locations_match): Call it.
> (disable_breakpoints_in_unloaded_shlib): Handle tracepoint.
> (download_tracepoint_locations): New.
> (update_global_location_list): Call it.
> * tracepoint.c (find_matching_tracepoint): Delete.
> (find_matching_tracepoint_location): Renamed from
> find_matching_tracepoint. Return bp_location rather than
> tracepoint.
> (merge_uploaded_tracepoints): Set `inserted' field to 1 if
> tracepoint is found.

This version is okay, thanks.

--
Pedro Alves