From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Yao Qi <yao@codesourcery.com>
Subject: Re: [patch 8/8] Test cases
Date: Thu, 10 Nov 2011 18:28:00 -0000 [thread overview]
Message-ID: <201111101828.34184.pedro@codesourcery.com> (raw)
In-Reply-To: <4EB8D25E.2080705@codesourcery.com>
On Tuesday 08 November 2011 06:55:26, Yao Qi wrote:
>
> These new test cases are to verify that tracepoint changed after
> `tstart' still work properly. There are two FAILs in change-loc.exp on
> x86_64-linux, but they are not related to this patch set. They are
> caused by an existing problem that jmp insn is incorrectly generated in
> jump pad if offset exceeds the limit of integer (32-bit). It could
> happen on x86_64 system.
We were meant to error out in these cases. Guess something's missing.
> +set testfile "change-loc"
> +set libfile1 "change-loc-1"
> +set libfile2 "change-loc-2"
> +set srcfile $testfile.c
> +set executable $testfile
> +set libsrc1 $srcdir/$subdir/$libfile1.c
> +set libsrc2 $srcdir/$subdir/$libfile2.c
Spurious spaces.
> +set binfile $objdir/$subdir/$testfile
> +set lib_sl1 $objdir/$subdir/$libfile1.sl
> +set lib_sl2 $objdir/$subdir/$libfile2.sl
Ditto.
> +
> +set lib_opts debug
Ditto.
Please make sure the new test messages are unique:
$ cat testsuite/gdb.sum | grep "PASS" | sort | uniq -c | sort -n | tail -n 15
1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstart
1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstop
1 PASS: gdb.trace/trace-break.exp: IPA loaded
2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@0: ftrace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@1: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace ftrace@1: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace trace@0: trace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace ftrace@0: ftrace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace trace@1: trace set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@0: trace after_set_point
2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@1: trace set_point
2 PASS: gdb.trace/trace-break.exp: 6 ftrace disable ftrace enable: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 6 ftrace enable ftrace disable: ftrace set_point
2 PASS: gdb.trace/trace-break.exp: 6 trace disable trace enable: trace set_point
2 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: trace set_point
Otherwise okay.
--
Pedro Alves
next prev parent reply other threads:[~2011-11-10 18:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 6:00 [patch 0/8] Download tracepoint locations when tracing is running Yao Qi
2011-11-08 6:08 ` [patch 1/8] Download tracepoint on location level Yao Qi
2011-11-09 3:34 ` Yao Qi
2011-11-10 14:54 ` Pedro Alves
2011-11-08 6:12 ` [patch 2/8] New remote feature InstallInTrace Yao Qi
2011-11-10 15:03 ` Pedro Alves
2011-11-08 6:21 ` [patch 3/8] New target hook `to_can_download_tracepoint_loc' Yao Qi
2011-11-10 15:11 ` Pedro Alves
2011-11-08 6:30 ` [patch 4/8] Download tracepoint locations and track its status Yao Qi
2011-11-09 3:47 ` Yao Qi
2011-11-10 15:51 ` Pedro Alves
2011-11-12 2:11 ` Yao Qi
2011-11-14 12:24 ` Pedro Alves
2011-11-08 6:33 ` [patch 5/8] refactor gdbserver on installing fast tracepoint Yao Qi
2011-11-10 15:57 ` Pedro Alves
2011-11-08 6:40 ` [patch 6/8] gdbserver - Install tracepoint when tracing is running Yao Qi
2011-11-08 8:20 ` Eli Zaretskii
2011-11-08 8:41 ` Yao Qi
2011-11-08 11:38 ` Eli Zaretskii
2011-11-10 16:53 ` Pedro Alves
2011-11-12 2:40 ` Yao Qi
2011-11-14 12:32 ` Pedro Alves
2011-11-08 6:43 ` [patch 7/8] Documentation changes Yao Qi
2011-11-08 8:37 ` Eli Zaretskii
2011-11-10 17:02 ` Pedro Alves
2011-11-12 3:09 ` Yao Qi
2011-11-08 6:56 ` [patch 8/8] Test cases Yao Qi
2011-11-10 17:16 ` Pedro Alves
2011-11-10 18:28 ` Pedro Alves [this message]
2011-11-12 3:35 ` Yao Qi
2011-11-14 13:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111101828.34184.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox