From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27300 invoked by alias); 10 Nov 2011 18:28:57 -0000 Received: (qmail 27290 invoked by uid 22791); 10 Nov 2011 18:28:56 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 18:28:39 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ROZMc-0006Zw-8p from pedro_alves@mentor.com for gdb-patches@sourceware.org; Thu, 10 Nov 2011 10:28:38 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 10 Nov 2011 18:28:36 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch 8/8] Test cases Date: Thu, 10 Nov 2011 18:28:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: Yao Qi References: <4EB8C551.9090609@codesourcery.com> <4EB8D25E.2080705@codesourcery.com> In-Reply-To: <4EB8D25E.2080705@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111101828.34184.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00288.txt.bz2 On Tuesday 08 November 2011 06:55:26, Yao Qi wrote: > > These new test cases are to verify that tracepoint changed after > `tstart' still work properly. There are two FAILs in change-loc.exp on > x86_64-linux, but they are not related to this patch set. They are > caused by an existing problem that jmp insn is incorrectly generated in > jump pad if offset exceeds the limit of integer (32-bit). It could > happen on x86_64 system. We were meant to error out in these cases. Guess something's missing. > +set testfile "change-loc" > +set libfile1 "change-loc-1" > +set libfile2 "change-loc-2" > +set srcfile $testfile.c > +set executable $testfile > +set libsrc1 $srcdir/$subdir/$libfile1.c > +set libsrc2 $srcdir/$subdir/$libfile2.c Spurious spaces. > +set binfile $objdir/$subdir/$testfile > +set lib_sl1 $objdir/$subdir/$libfile1.sl > +set lib_sl2 $objdir/$subdir/$libfile2.sl Ditto. > + > +set lib_opts debug Ditto. Please make sure the new test messages are unique: $ cat testsuite/gdb.sum | grep "PASS" | sort | uniq -c | sort -n | tail -n 15 1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstart 1 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: tstop 1 PASS: gdb.trace/trace-break.exp: IPA loaded 2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@0: ftrace after_set_point 2 PASS: gdb.trace/trace-break.exp: 5 ftrace ftrace ftrace@1: ftrace set_point 2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace ftrace@1: ftrace set_point 2 PASS: gdb.trace/trace-break.exp: 5 ftrace trace trace@0: trace after_set_point 2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace ftrace@0: ftrace after_set_point 2 PASS: gdb.trace/trace-break.exp: 5 trace ftrace trace@1: trace set_point 2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@0: trace after_set_point 2 PASS: gdb.trace/trace-break.exp: 5 trace trace trace@1: trace set_point 2 PASS: gdb.trace/trace-break.exp: 6 ftrace disable ftrace enable: ftrace set_point 2 PASS: gdb.trace/trace-break.exp: 6 ftrace enable ftrace disable: ftrace set_point 2 PASS: gdb.trace/trace-break.exp: 6 trace disable trace enable: trace set_point 2 PASS: gdb.trace/trace-break.exp: 6 trace enable trace disable: trace set_point Otherwise okay. -- Pedro Alves