From: Yao Qi <yao@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 6/8] gdbserver - Install tracepoint when tracing is running
Date: Tue, 08 Nov 2011 08:41:00 -0000 [thread overview]
Message-ID: <4EB8EB28.2070300@codesourcery.com> (raw)
In-Reply-To: <E1RNgv4-0007F7-JD@fencepost.gnu.org>
On 11/08/2011 04:20 PM, Eli Zaretskii wrote:
>> + TPOINT is inserted at the last of them.
>
> "inserted at the last of them" is not clear. I would suggest using
> "before" or "after". Or maybe "at the highest address" if you mean
> "at address" (I don't really understand the meaning of what the code
> does.)
>
What I want to describe is there have been three, for example,
tracepoints setting at the same address, and the forth is to be set at
the same place as well, and insert the forth into linked list. What I
meant in comment is "insert the forth tracepoint after these three
existing tracepoints", and of course, there may be other tracepoints, at
higher address, after them in the list.
How about "TPOINT is inserted after all the tracepoints which are set at
the same address"?
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-11-08 8:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 6:00 [patch 0/8] Download tracepoint locations " Yao Qi
2011-11-08 6:08 ` [patch 1/8] Download tracepoint on location level Yao Qi
2011-11-09 3:34 ` Yao Qi
2011-11-10 14:54 ` Pedro Alves
2011-11-08 6:12 ` [patch 2/8] New remote feature InstallInTrace Yao Qi
2011-11-10 15:03 ` Pedro Alves
2011-11-08 6:21 ` [patch 3/8] New target hook `to_can_download_tracepoint_loc' Yao Qi
2011-11-10 15:11 ` Pedro Alves
2011-11-08 6:30 ` [patch 4/8] Download tracepoint locations and track its status Yao Qi
2011-11-09 3:47 ` Yao Qi
2011-11-10 15:51 ` Pedro Alves
2011-11-12 2:11 ` Yao Qi
2011-11-14 12:24 ` Pedro Alves
2011-11-08 6:33 ` [patch 5/8] refactor gdbserver on installing fast tracepoint Yao Qi
2011-11-10 15:57 ` Pedro Alves
2011-11-08 6:40 ` [patch 6/8] gdbserver - Install tracepoint when tracing is running Yao Qi
2011-11-08 8:20 ` Eli Zaretskii
2011-11-08 8:41 ` Yao Qi [this message]
2011-11-08 11:38 ` Eli Zaretskii
2011-11-10 16:53 ` Pedro Alves
2011-11-12 2:40 ` Yao Qi
2011-11-14 12:32 ` Pedro Alves
2011-11-08 6:43 ` [patch 7/8] Documentation changes Yao Qi
2011-11-08 8:37 ` Eli Zaretskii
2011-11-10 17:02 ` Pedro Alves
2011-11-12 3:09 ` Yao Qi
2011-11-08 6:56 ` [patch 8/8] Test cases Yao Qi
2011-11-10 17:16 ` Pedro Alves
2011-11-10 18:28 ` Pedro Alves
2011-11-12 3:35 ` Yao Qi
2011-11-14 13:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB8EB28.2070300@codesourcery.com \
--to=yao@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox