From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30699 invoked by alias); 8 Nov 2011 08:41:40 -0000 Received: (qmail 30690 invoked by uid 22791); 8 Nov 2011 08:41:39 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 08:41:26 +0000 Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RNhFF-0001sW-Ti from Yao_Qi@mentor.com ; Tue, 08 Nov 2011 00:41:26 -0800 Received: from [127.0.0.1] ([172.16.63.104]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 8 Nov 2011 17:41:24 +0900 Message-ID: <4EB8EB28.2070300@codesourcery.com> Date: Tue, 08 Nov 2011 08:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [patch 6/8] gdbserver - Install tracepoint when tracing is running References: <4EB8C551.9090609@codesourcery.com> <4EB8CEC4.9000905@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00183.txt.bz2 On 11/08/2011 04:20 PM, Eli Zaretskii wrote: >> + TPOINT is inserted at the last of them. > > "inserted at the last of them" is not clear. I would suggest using > "before" or "after". Or maybe "at the highest address" if you mean > "at address" (I don't really understand the meaning of what the code > does.) > What I want to describe is there have been three, for example, tracepoints setting at the same address, and the forth is to be set at the same place as well, and insert the forth into linked list. What I meant in comment is "insert the forth tracepoint after these three existing tracepoints", and of course, there may be other tracepoints, at higher address, after them in the list. How about "TPOINT is inserted after all the tracepoints which are set at the same address"? -- Yao (齐尧)