From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85005-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15233 invoked by alias); 8 Nov 2011 08:37:04 -0000
Received: (qmail 15151 invoked by uid 22791); 8 Nov 2011 08:37:03 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 08:36:50 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1RNhAm-0008QB-Nq; Tue, 08 Nov 2011 03:36:48 -0500
Date: Tue, 08 Nov 2011 08:37:00 -0000
Message-Id: <E1RNhAm-0008QB-Nq@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches@sourceware.org
In-reply-to: <4EB8CF86.9080303@codesourcery.com> (message from Yao Qi on Tue,	08 Nov 2011 14:43:18 +0800)
Subject: Re: [patch 7/8] Documentation changes
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <4EB8C551.9090609@codesourcery.com> <4EB8CF86.9080303@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00182.txt.bz2

> Date: Tue, 08 Nov 2011 14:43:18 +0800
> From: Yao Qi <yao@codesourcery.com>
> 
> This patch is about documentation changes to reflect 1) the changes on
> tracepoint behavior, 2) a new remote feature.

Thanks.  A few comments about this part:

>  data, and then allow the program to continue.  Setting a tracepoint or
> -changing its actions doesn't take effect until the next @code{tstart}
> +changing its actions takes effect immediately, which  depends on the
> +remote stub's support of @samp{InstallInTrace} feature

I think you meant something like this:

  Setting a tracepoint or changing its actions takes effect
  immediately if the remote stub supports the @samp{InstallInTrace}
  feature.

>                                                        (see
> +@ref{install tracepoint in tracing})for remote targets.

Please use @pxref here, which does TRT for a cross-reference in
parentheses; @ref doesn't (it needs a comma or a period after the
closing brace; makeinfo will bitch at you if you don't put one or the
other).

> +If remote stub doesn't support @samp{InstallInTrace} feature, all these
                                ^^
"the" is missing here.

Okay with these changes.