RE: h8/300 sim tests

RE: h8/300 sim tests

[D.Venkatasubramanian, Noida]

Hi All,

Sorry for the late reply.
This is wonderful. And I got the hint. ;-) I will try to
add some tests for File I/O and Cmdline, once I get free
from some other work I am doing.

I don't think MAC is supported though I did submit a
basic patch. It hasn't been approved still.

I don't think, mac.s should be run for all.
(Only H8S ...)

Thanks and Regards,

Venky

>-----Original Message-----
>From: Michael Snyder [mailto:msnyder@redhat.com]
>Sent: Monday, April 07, 2003 7:11 PM
>To: gdb-patches@sources.redhat.com
>Cc: D.Venkatasubramanian, Noida; kazu@cs.umass.edu; 
>avolkov@transas.com;
>cagney@redhat.com
>Subject: h8/300 sim tests
>
>
>Hi guys, 
>
>I've been working on some tests for the h8/300 simulator, and I've
>decided they're ready for contribution.  I hope this framework will
>make it easy for others to add tests (hint hint file i/o cmdline).
>These are meant to go in a new directory sim/testsuite/sim/h8300.
>
>You'll immediately see from this that I'm also working on adding
>the h8sx architecture.  Look for that submission shortly.  These
>tests will work as is, without that submission, with just a few
>failures (which probably represent existing bugs).
>
>Cheers, 
>Michael Snyder
>

Re: h8/300 sim tests

[Kazu Hirata]

Hi Michael,

> I've been working on some tests for the h8/300 simulator, and I've
> decided they're ready for contribution.  I hope this framework will
> make it easy for others to add tests (hint hint file i/o cmdline).
> These are meant to go in a new directory sim/testsuite/sim/h8300.

This is cool, especially because the simulator are not good at
simulating instructions that gcc does not output. :-(

> You'll immediately see from this that I'm also working on adding
> the h8sx architecture.  Look for that submission shortly.  These
> tests will work as is, without that submission, with just a few
> failures (which probably represent existing bugs).

Would you mind sharing some of the failures you've found?

Kazu Hirata

Re: h8/300 sim tests

[Michael Snyder]

Kazu Hirata wrote:
> 
> Hi Michael,
> 
> > I've been working on some tests for the h8/300 simulator, and I've
> > decided they're ready for contribution.  I hope this framework will
> > make it easy for others to add tests (hint hint file i/o cmdline).
> > These are meant to go in a new directory sim/testsuite/sim/h8300.
> 
> This is cool, especially because the simulator are not good at
> simulating instructions that gcc does not output. :-(
> 
> > You'll immediately see from this that I'm also working on adding
> > the h8sx architecture.  Look for that submission shortly.  These
> > tests will work as is, without that submission, with just a few
> > failures (which probably represent existing bugs).
> 
> Would you mind sharing some of the failures you've found?

Heck, I'll even send you patches.  ;-)
You can run these tests yourself -- I think you'll see failures in
ldc/stc (patch to follow), and daa/das (not implemented yet), and
shal/shll (carry is wrong, patch to follow).

Install the patch in src/sim/testsuite/sim/h8300 (except for the
configure change, which goes in src/sim.  Run configure, build, 
install (required), and then cd build/sim/testsuite and run 
	make check RUNTESTFLAGS=allinsn.exp

It runs pretty quickly.

Re: h8/300 sim tests

[Michael Snyder]

Kazu Hirata wrote:
> 
> Hi Michael,
> 
> > I've been working on some tests for the h8/300 simulator, and I've
> > decided they're ready for contribution.  I hope this framework will
> > make it easy for others to add tests (hint hint file i/o cmdline).
> > These are meant to go in a new directory sim/testsuite/sim/h8300.
> 
> This is cool, especially because the simulator are not good at
> simulating instructions that gcc does not output. :-(

Kazu -- I know you're not the maintainer, but if you were, 
would you be inclined to approve?  I'll take it as a peer review.   ;-)

Michael

Re: h8/300 sim tests

[Kazu Hirata]

Hi Michael,

> I've been working on some tests for the h8/300 simulator, and I've
> decided they're ready for contribution.  I hope this framework will
> make it easy for others to add tests (hint hint file i/o cmdline).
> These are meant to go in a new directory sim/testsuite/sim/h8300.

I just looked at the patch.  This is great!

But I am a little concerned about its size, though.  You've written
this macro.

+ 	.macro test_cc_clear
+ 	test_carry_clear
+ 	test_ovf_clear
+ 	test_zero_clear
+ 	test_neg_clear
+ 		; leaves H, I, U, and UI untested
+ 	.endm

but I still see a lot of

+ 	test_carry_clear	; H=0 N=0 Z=0 V=0 C=0
+ 	test_ovf_clear
+ 	test_zero_clear
+ 	test_neg_clear

In and.w.s, or.w.s, and xor.w.s, I see a nest of

+ .if (sim_cpu)			; non-zero means h8300h, s, or sx

which you probably didn't mean.

I think we should have more macros that test that registers have not
changed like test_gr_a5a5_0_7 and test_gr_a5a5_1_7.

Having said all these, maybe we can first commit your patch and then
work on CVS.  I am willing to help here.

Kazu Hirata

Re: h8/300 sim tests

[Michael Snyder]

Kazu Hirata wrote:
> 
> Hi Michael,
> 
> > I've been working on some tests for the h8/300 simulator, and I've
> > decided they're ready for contribution.  I hope this framework will
> > make it easy for others to add tests (hint hint file i/o cmdline).
> > These are meant to go in a new directory sim/testsuite/sim/h8300.
> 
> I just looked at the patch.  This is great!
> 
> But I am a little concerned about its size, though.  You've written
> this macro.
> 
> +       .macro test_cc_clear
> +       test_carry_clear
> +       test_ovf_clear
> +       test_zero_clear
> +       test_neg_clear
> +               ; leaves H, I, U, and UI untested
> +       .endm
> 
> but I still see a lot of
> 
> +       test_carry_clear        ; H=0 N=0 Z=0 V=0 C=0
> +       test_ovf_clear
> +       test_zero_clear
> +       test_neg_clear

I only use the test_cc_clear when I expect it to always be clear.
When it varies from one test to the next (eg. the neg flag may
be set one time, clear the next time), I spell them all out.


> In and.w.s, or.w.s, and xor.w.s, I see a nest of
> 
> + .if (sim_cpu)                 ; non-zero means h8300h, s, or sx
> 
> which you probably didn't mean.

I did mean it -- but it's short for "if (sim_cpu != 0)", 
which the assembler seems not to like.  Zero happens to 
be the enum value for the plain vanilla h8/300, so this
idiom means "if h8300h or h8300s or h8300sx".


> I think we should have more macros that test that registers have not
> changed like test_gr_a5a5_0_7 and test_gr_a5a5_1_7.

Sure -- feel free to add them!

> Having said all these, maybe we can first commit your patch and then
> work on CVS.  I am willing to help here.

Cool - I will commit it by Monday EOB.

Thanks for your review, Kazu!
Michael

Re: h8/300 sim tests

[Michael Snyder]

Kazu Hirata wrote:
> 
> Hi Michael,
> 
> > I've been working on some tests for the h8/300 simulator, and I've
> > decided they're ready for contribution.  I hope this framework will
> > make it easy for others to add tests (hint hint file i/o cmdline).
> > These are meant to go in a new directory sim/testsuite/sim/h8300.
> 
> I just looked at the patch.  This is great!

OK, committed.  Revise away.