From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1026 invoked by alias); 12 Apr 2003 18:40:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1019 invoked from network); 12 Apr 2003 18:39:59 -0000 Received: from unknown (HELO mail.cs.umass.edu) (128.119.243.168) by sources.redhat.com with SMTP; 12 Apr 2003 18:39:59 -0000 Received: from localhost (IDENT:7aSs9IOg8jx1gM1+DW7F2QhpK1k5wfIr@loki.cs.umass.edu [128.119.243.168]) by mail.cs.umass.edu (8.12.6/8.12.5) with ESMTP id h3CIdJjf020896; Sat, 12 Apr 2003 14:39:20 -0400 Date: Sat, 12 Apr 2003 18:40:00 -0000 Message-Id: <20030412.143919.126765664.kazu@cs.umass.edu> To: msnyder@redhat.com Cc: gdb-patches@sources.redhat.com, dvenkat@noida.hcltech.com, avolkov@transas.com, cagney@redhat.com Subject: Re: h8/300 sim tests From: Kazu Hirata In-Reply-To: <3E917FF6.4699C121@redhat.com> References: <3E917FF6.4699C121@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Checked: This message probably not SPAM X-Spam-Score: -19.8, Required: 5 X-Spam-Tests: IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES X-Spam-Report: ---- Start SpamAssassin results -19.80 points, 5 required; * -6.6 -- Has a valid-looking References header * -3.3 -- Has a In-Reply-To header * -3.3 -- BODY: Contains what looks like a quoted email text * -6.6 -- Reply with quoted text ---- End of SpamAssassin results X-Scanned-By: MIMEDefang 2.30 (www . roaringpenguin . com / mimedefang) X-SW-Source: 2003-04/txt/msg00253.txt.bz2 Hi Michael, > I've been working on some tests for the h8/300 simulator, and I've > decided they're ready for contribution. I hope this framework will > make it easy for others to add tests (hint hint file i/o cmdline). > These are meant to go in a new directory sim/testsuite/sim/h8300. I just looked at the patch. This is great! But I am a little concerned about its size, though. You've written this macro. + .macro test_cc_clear + test_carry_clear + test_ovf_clear + test_zero_clear + test_neg_clear + ; leaves H, I, U, and UI untested + .endm but I still see a lot of + test_carry_clear ; H=0 N=0 Z=0 V=0 C=0 + test_ovf_clear + test_zero_clear + test_neg_clear In and.w.s, or.w.s, and xor.w.s, I see a nest of + .if (sim_cpu) ; non-zero means h8300h, s, or sx which you probably didn't mean. I think we should have more macros that test that registers have not changed like test_gr_a5a5_0_7 and test_gr_a5a5_1_7. Having said all these, maybe we can first commit your patch and then work on CVS. I am willing to help here. Kazu Hirata