Re: h8/300 sim tests

[Kazu Hirata <kazu@cs.umass.edu>]

Hi Michael,

> I've been working on some tests for the h8/300 simulator, and I've
> decided they're ready for contribution.  I hope this framework will
> make it easy for others to add tests (hint hint file i/o cmdline).
> These are meant to go in a new directory sim/testsuite/sim/h8300.

I just looked at the patch.  This is great!

But I am a little concerned about its size, though.  You've written
this macro.

+ 	.macro test_cc_clear
+ 	test_carry_clear
+ 	test_ovf_clear
+ 	test_zero_clear
+ 	test_neg_clear
+ 		; leaves H, I, U, and UI untested
+ 	.endm

but I still see a lot of

+ 	test_carry_clear	; H=0 N=0 Z=0 V=0 C=0
+ 	test_ovf_clear
+ 	test_zero_clear
+ 	test_neg_clear

In and.w.s, or.w.s, and xor.w.s, I see a nest of

+ .if (sim_cpu)			; non-zero means h8300h, s, or sx

which you probably didn't mean.

I think we should have more macros that test that registers have not
changed like test_gr_a5a5_0_7 and test_gr_a5a5_1_7.

Having said all these, maybe we can first commit your patch and then
work on CVS.  I am willing to help here.

Kazu Hirata