RE: [PATCH v3 2/2] gdb: add a '-stopped' option to "info threads"

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Thursday, April 24, 2025 9:23 PM, Pedro Alves wrote:
> Hi!
> 
> On 2025-04-04 14:36, Tankut Baris Aktemur wrote:
> > Add a '-stopped' option to the "info threads" command to print stopped
> > threads only and skip the running ones.  This is a convenience flag to
> > filter out the running threads in programs that have many threads.
> >
> > Suppose we have an application with 5 threads, 2 of which have hit a
> > breakpoint.  The "info threads" command in the non-stop mode gives:
> >
> >   (gdb) info threads
> >     Id   Target Id             Frame
> >   * 1    Thread 0x7ffff7d99740 (running)
> >     2    Thread 0x7ffff7d98700 something () at file.c:30
> >     3    Thread 0x7ffff7597700 (running)
> >     4    Thread 0x7ffff6d96700 something () at file.c:30
> >     5    Thread 0x7ffff6595700 (running)
> >   (gdb)
> >
> > Using the "-stopped" flag, we get
> >
> >   (gdb) info threads -stopped
> >     Id   Target Id             Frame
> >     2    Thread 0x7ffff7d98700 something () at file.c:30
> >     4    Thread 0x7ffff6d96700 something () at file.c:30
> >   (gdb)
> >
> > When combined with a thread ID, the behavior is as follows:
> >
> >   (gdb) info threads 3
> >     Id   Target Id             Frame
> >     3    Thread 0x7ffff7597700 (running)
> >   (gdb) info threads -stopped 3
> >   No stopped threads match '3'.
> >   (gdb)
> >
> > Regression-tested on X86_64 Linux.
> >
> > Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> > Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
> > ---
> >  gdb/NEWS                                      |   5 +
> >  gdb/doc/gdb.texinfo                           |   6 +-
> >  gdb/testsuite/gdb.base/options.exp            |  11 +-
> >  .../gdb.threads/info-threads-stopped.c        |  78 +++++++++++++
> >  .../gdb.threads/info-threads-stopped.exp      | 107 ++++++++++++++++++
> >  gdb/thread.c                                  |  17 ++-
> >  6 files changed, 220 insertions(+), 4 deletions(-)
> >  create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.c
> >  create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.exp
> >
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 6a557bb4af9..d5c55c3c938 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -56,6 +56,11 @@ info sharedlibrary
> >    command are now for the full memory range allocated to the shared
> >    library.
> >
> > +info threads [-gid] [-stopped] [ID]...
> > +  This command now takes an optional flag, '-stopped', that causes only
> > +  the stopped threads to be printed.  The flag can be useful to get a
> > +  reduced list when there is a large number of unstopped threads.
> 
> 
> Cool!
> 
> (I would have added -running too while at it, and make "thread apply -stopped" work too.
> 
>  And then:
> 
>   "info threads -stopped -running"
> 
>  would print both stopped and running.
> 
>  Same logic as "info lanes -active -inactive" including both active and inactive in
>  our offlist discussions.)

Hi Pedro,

Thanks a lot for the thorough review.  I'll soon send the next revision.
I also added "-running" per your suggestion, but let's please complete this
series first.  I'd like to send "thread apply -stopped" separately.

Thank you.
-Baris

 

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928