RE: [PATCH v2 0/2] Option to show stopped threads only

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Friday, March 28, 2025 5:38 PM, Guinevere Larsen wrote:
> On 3/18/25 3:04 PM, Tankut Baris Aktemur wrote:
> > Hi,
> >
> > This is the rebased version of
> >
> >    https://inbox.sourceware.org/gdb-
> patches/cover.1680686220.git.tankut.baris.aktemur@intel.com/
> >
> > As a comment, Eli had expressed his view that when "info threads" is
> > given a single thread ID, the "-stopped" flag could be ignored.  I
> > didn't implement this yet but can gladly do that if that's the general
> > preference.
> 
> Hi! Thanks for working on this!
> 
> I took a look at your patch, and I think I like how it works at this
> point. Basically, I don't like the idea of ignoring part of the input
> from the user if a different part of the input happens to look a certain
> way (in this case non-empty). Either both options should interact, or
> they should be mutually exclusive, and allowing one to take precedence
> just inserts arbitrary rules that users need to either remember or
> double check the manual every time. However, this is personal
> preference, I'm not married to either idea.
> 
> One thing that would be nice, though, would be also testing the behavior
> when a thread ID is given - whatever that behavior is. Adding a couple
> of tests calling one stopped ID, one running ID and multiple IDs, would
> essentially document to ourselves that "this is the behavior we want,it
> isn't an accident" so that if it is changed in the future, it is done so
> on purpose.
> 
> As for the patches themselves, they look good to me. I hope this gets
> reviewed soon!
> 
> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>

Thank you for your review and comments.  I added the new test cases and submitted v3.

Regards
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928