Re: [PATCH v4 3/3] gdb: add '-stopped' and '-running' options to "info threads"

[Eli Zaretskii <eliz@gnu.org>]

> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Cc: guinevere@redhat.com,
> 	eliz@gnu.org,
> 	pedro@palves.net
> Date: Mon,  5 May 2025 18:19:31 +0200
> 
> Add two options to "info threads": `-stopped` and `-running`.
> 
> The purpose of these options is to filter the output of the command.
> The `-stopped` option means "print stopped threads only" and,
> similarly, `-running` means "print the running threads only".  When
> both options are provided by the user, the indication is that the user
> wants the union.  That is, the output contains both stopped and
> running threads.
> 
> Suppose we have an application with 5 threads, 2 of which have hit a
> breakpoint.  The "info threads" command in the non-stop mode gives:
> 
>   (gdb) info threads
>     Id   Target Id             Frame
>   * 1    Thread 0x7ffff7d99740 (running)
>     2    Thread 0x7ffff7d98700 something () at file.c:30
>     3    Thread 0x7ffff7597700 (running)
>     4    Thread 0x7ffff6d96700 something () at file.c:30
>     5    Thread 0x7ffff6595700 (running)
>   (gdb)
> 
> Using the "-stopped" flag, we get
> 
>   (gdb) info threads -stopped
>     Id   Target Id             Frame
>     2    Thread 0x7ffff7d98700 something () at file.c:30
>     4    Thread 0x7ffff6d96700 something () at file.c:30
>   (gdb)
> 
> Using the "-running" flag, we get
> 
>   (gdb) info threads -running
>     Id   Target Id             Frame
>   * 1    Thread 0x7ffff7d99740 (running)
>     3    Thread 0x7ffff7597700 (running)
>     5    Thread 0x7ffff6595700 (running)
>   (gdb)
> 
> Using both flags prints all:
> 
>   (gdb) info threads -stopped -running
>     Id   Target Id             Frame
>   * 1    Thread 0x7ffff7d99740 (running)
>     2    Thread 0x7ffff7d98700 something () at file.c:30
>     3    Thread 0x7ffff7597700 (running)
>     4    Thread 0x7ffff6d96700 something () at file.c:30
>     5    Thread 0x7ffff6595700 (running)
>   (gdb)
> 
> When combined with a thread ID, filtering applies to those threads that
> are matched by the ID.
> 
>   (gdb) info threads 3
>     Id   Target Id             Frame
>     3    Thread 0x7ffff7597700 (running)
>   (gdb) info threads -stopped 3
>   No threads matched.
>   (gdb)
> 
> Regression-tested on X86_64 Linux.
> 
> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
> ---
>  gdb/NEWS                                      |  11 +-
>  gdb/doc/gdb.texinfo                           |  10 +-
>  gdb/testsuite/gdb.base/options.exp            |  16 ++-
>  .../gdb.threads/info-threads-options.c        |  77 ++++++++++
>  .../gdb.threads/info-threads-options.exp      | 131 ++++++++++++++++++
>  gdb/thread.c                                  |  41 ++++--
>  6 files changed, 272 insertions(+), 14 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.threads/info-threads-options.c
>  create mode 100644 gdb/testsuite/gdb.threads/info-threads-options.exp

Thanks.

The documentation parts are okay, but my suggestion is to drop the
part that talks about "union": it adds nothing useful to the
description.  IOW, this:

  If you specify both options, @value{GDBN} prints both stopped and
  running threads.

is enough and tells the whole story.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>