Re: [PATCH v3 1/2] gdb: pass info_threads_opts to print_thread_info_1

[Pedro Alves <pedro@palves.net>]

On 2025-04-04 14:36, Tankut Baris Aktemur wrote:

>  /* Helper for print_thread_info.  Returns true if THR should be
>     printed.  If REQUESTED_THREADS, a list of GDB ids/ranges, is not
>     NULL, only print THR if its ID is included in the list.  GLOBAL_IDS
> @@ -1046,11 +1064,13 @@ pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread)
>     is a thread from the process PID.  Otherwise, threads from all
>     attached PIDs are printed.  If both REQUESTED_THREADS is not NULL
>     and PID is not -1, then the thread is printed if it belongs to the
> -   specified process.  Otherwise, an error is raised.  */
> +   specified process.  Otherwise, an error is raised.  OPTS is the
> +   options of the "info threads" command.  */
>  
>  static bool
>  should_print_thread (const char *requested_threads, int default_inf_num,
> -		     int global_ids, int pid, struct thread_info *thr)
> +		     int global_ids, int pid, thread_info *thr,
> +		     info_threads_opts opts)

Would you mind making that argument be the one after "requested_threads"?  I.e.,
make it the second argument.  That is so that both user-input arguments are next to
one another.  And make it a const ref, as this structure will grow
other fields and become larger.  I.e., write:

static bool
should_print_thread (const char *requested_threads, 
                     const info_threads_opts &opts,
                     int default_inf_num,
                     ...

Same logic for the other functions.

>      /* This end scope restores the current thread and the frame
> @@ -1322,27 +1342,10 @@ void
>  print_thread_info (struct ui_out *uiout, const char *requested_threads,
>  		   int pid)
>  {
> -  print_thread_info_1 (uiout, requested_threads, 1, pid, 0);
> +  info_threads_opts opts {false};

This can be just:

   info_threads_opts opts;

as the boolean field has an in-class initializer.

With that it LGTM.

Pedro Alves