RE: [PATCH 3/3] gdb: add a '-stopped' option to "info threads"

["Aktemur, Tankut Baris via Gdb-patches" <gdb-patches@sourceware.org>]

On Wednesday, April 5, 2023 12:01 PM, Eli Zaretskii wrote:
> > Date: Wed,  5 Apr 2023 11:20:02 +0200
> > From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
> >
> >  gdb/NEWS                                      |  7 ++
> >  gdb/doc/gdb.texinfo                           |  6 +-
> >  gdb/testsuite/gdb.base/options.exp            | 11 ++-
> >  .../gdb.threads/info-threads-stopped.c        | 78 +++++++++++++++++++
> >  .../gdb.threads/info-threads-stopped.exp      | 75 ++++++++++++++++++
> >  gdb/thread.c                                  | 17 +++-
> >  6 files changed, 190 insertions(+), 4 deletions(-)
> >  create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.c
> >  create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.exp
> 
> Thanks, the documentation parts are OK.
> 
> But I have a question about the new behavior:
> 
> >   (gdb) info threads -stopped 3
> >   No stopped threads match '3'.
> 
> Is it really useful to show nothing and emit an error message if
> explicit thread IDs were specified by the user?  Wouldn't it be better
> to ignore the -stopped switch in that case?
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

The user may have given a thread id range or a wildcard, like
"info threads -stopped 1-999" or "info threads -stopped 2.*".
Ignoring the flag for these cases can output a very long list.

I'm fine if we make the single thread id a special case.  But then
the question is, where do we draw the line?  If the user gave just a
few thread ids, do we still ignore the flag?  What is the limit to
the acceptable list length?  Because of these questions, consistently
applying the flag made more sense to me.

Regards
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928