From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>,
Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 7/8] Remove readline hack from gdb_select
Date: Wed, 07 Aug 2019 22:16:00 -0000 [thread overview]
Message-ID: <CAPTJ0XEfqHXvJburVwoODwaFFrXR+SkUKEkY4vvBN1oStbfexg@mail.gmail.com> (raw)
In-Reply-To: <871rxwfxah.fsf@tromey.com>
On Wed, Aug 7, 2019 at 5:03 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 8/6/19 9:43 PM, Tom Tromey wrote:
> >> As discussed on gdb-patches, this removes the readline hack from the
> >> mingw-hdep.c version of gdb_select. It's believed that this is not
> >> needed any more.
>
> Pedro> I may be hard to find the discussion later on.
> Pedro> Please add a link to the discussion to the commit log
> Pedro> pointing here:
>
> Pedro> https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html
>
> Thanks, I did this.
>
> Also, Christian Biesinger managed to build this branch on Windows and
> try it, which is very good news.
Yep, it worked fine (up/down arrow worked, Ctrl+R worked).
For reference, I compiled in cygwin but with mingw, using:
../configure --disable-binutils --disable-gas --disable-gold
--disable-gprof --disable-ld --disable-werror --disable-nls
I had to copy libwinpthread-1.dll to out/gdb.
Christian
next prev parent reply other threads:[~2019-08-07 22:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 20:43 [PATCH 0/8] Upgrade readline Tom Tromey
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02 ` [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp Tom de Vries
2019-08-06 20:43 ` [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c Tom Tromey
2019-08-06 20:43 ` [PATCH 8/8] Require readline 7 or newer Tom Tromey
2019-08-07 2:27 ` Eli Zaretskii
2019-08-07 14:42 ` Pedro Alves
2019-08-07 22:31 ` Tom Tromey
2019-08-08 2:37 ` Eli Zaretskii
2019-08-08 11:26 ` Pedro Alves
2019-08-08 11:29 ` Pedro Alves
2019-08-08 20:38 ` Tom Tromey
2019-08-07 14:45 ` Pedro Alves
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29 ` Pedro Alves
2019-08-07 22:03 ` Tom Tromey
2019-08-07 22:16 ` Christian Biesinger via gdb-patches [this message]
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-07 3:05 ` [PATCH 0/8] Upgrade readline Kevin Buettner
2019-08-07 13:38 ` Tom Tromey
2019-08-07 13:40 ` Tom Tromey
2019-08-14 10:21 ` Tom de Vries
2019-08-15 13:46 ` Tom Tromey
2019-08-19 16:38 ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31 ` Tom Tromey
2019-08-12 19:46 ` Sergio Durigan Junior
2019-08-12 19:52 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XEfqHXvJburVwoODwaFFrXR+SkUKEkY4vvBN1oStbfexg@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox