From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 0/8] Upgrade readline
Date: Wed, 07 Aug 2019 03:05:00 -0000 [thread overview]
Message-ID: <20190806200520.2c520f05@f29-4.lan> (raw)
In-Reply-To: <20190806204334.13441-1-tom@tromey.com>
On Tue, 6 Aug 2019 14:43:26 -0600
Tom Tromey <tom@tromey.com> wrote:
> Here's the series to upgrade readline. This has been sitting around
> for a while and I thought I would finally send it.
>
> I built it on a Windows machine at AdaCore, but although readline is
> built and gdb links against it, I can't get it to work. Maybe this is
> due to whatever remote terminal I am using -- I don't know.
>
> Tested on x86-64 Fedora 28. Also, note that the major distros use
> --with-system-readline, which I think is further evidence that this
> works.
>
> This was too big to test on the buildbot.
>
> Let me know what you think.
I glanced at patches 2-5, and 8. For some reason, 1 and 6 haven't
shown up yet. The ones I've looked at look reasonable.
I tried building GDB on one of the BSDs earlier this year, which lacked
an obvious system readline. (It was available, but I either had to
install it or tell configure where it was, maybe both.) In any case,
I had build problems with the in-tree readline. I then tried building
GDB on F29 with system readline disabled and ran into the same
problems. So I'm in favor of anything which fixes that breakage.
So, basically, if it builds, I think it should go in.
Kevin
next prev parent reply other threads:[~2019-08-07 3:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 20:43 Tom Tromey
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29 ` Pedro Alves
2019-08-07 22:03 ` Tom Tromey
2019-08-07 22:16 ` Christian Biesinger via gdb-patches
2019-08-06 20:43 ` [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c Tom Tromey
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02 ` [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp Tom de Vries
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-06 20:43 ` [PATCH 8/8] Require readline 7 or newer Tom Tromey
2019-08-07 2:27 ` Eli Zaretskii
2019-08-07 14:42 ` Pedro Alves
2019-08-07 22:31 ` Tom Tromey
2019-08-08 2:37 ` Eli Zaretskii
2019-08-08 11:26 ` Pedro Alves
2019-08-08 11:29 ` Pedro Alves
2019-08-08 20:38 ` Tom Tromey
2019-08-07 14:45 ` Pedro Alves
2019-08-07 3:05 ` Kevin Buettner [this message]
2019-08-07 13:38 ` [PATCH 0/8] Upgrade readline Tom Tromey
2019-08-07 13:40 ` Tom Tromey
2019-08-14 10:21 ` Tom de Vries
2019-08-15 13:46 ` Tom Tromey
2019-08-19 16:38 ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31 ` Tom Tromey
2019-08-12 19:46 ` Sergio Durigan Junior
2019-08-12 19:52 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806200520.2c520f05@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox