From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128612 invoked by alias); 7 Aug 2019 03:05:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128563 invoked by uid 89); 7 Aug 2019 03:05:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=evidence X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 03:05:22 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4DF1C30BA1AB; Wed, 7 Aug 2019 03:05:21 +0000 (UTC) Received: from f29-4.lan (ovpn-117-6.phx2.redhat.com [10.3.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 223BA60A9D; Wed, 7 Aug 2019 03:05:21 +0000 (UTC) Date: Wed, 07 Aug 2019 03:05:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 0/8] Upgrade readline Message-ID: <20190806200520.2c520f05@f29-4.lan> In-Reply-To: <20190806204334.13441-1-tom@tromey.com> References: <20190806204334.13441-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00167.txt.bz2 On Tue, 6 Aug 2019 14:43:26 -0600 Tom Tromey wrote: > Here's the series to upgrade readline. This has been sitting around > for a while and I thought I would finally send it. > > I built it on a Windows machine at AdaCore, but although readline is > built and gdb links against it, I can't get it to work. Maybe this is > due to whatever remote terminal I am using -- I don't know. > > Tested on x86-64 Fedora 28. Also, note that the major distros use > --with-system-readline, which I think is further evidence that this > works. > > This was too big to test on the buildbot. > > Let me know what you think. I glanced at patches 2-5, and 8. For some reason, 1 and 6 haven't shown up yet. The ones I've looked at look reasonable. I tried building GDB on one of the BSDs earlier this year, which lacked an obvious system readline. (It was available, but I either had to install it or tell configure where it was, maybe both.) In any case, I had build problems with the in-tree readline. I then tried building GDB on F29 with system readline disabled and ran into the same problems. So I'm in favor of anything which fixes that breakage. So, basically, if it builds, I think it should go in. Kevin