From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 8/8] Require readline 7 or newer
Date: Tue, 06 Aug 2019 20:43:00 -0000 [thread overview]
Message-ID: <20190806204334.13441-9-tom@tromey.com> (raw)
In-Reply-To: <20190806204334.13441-1-tom@tromey.com>
This changes gdb to require readline 7 or newer at build time.
2019-04-21 Tom Tromey <tom@tromey.com>
* README: Update.
* event-top.c: Require readline 7.
gdb/doc/ChangeLog
2019-04-21 Tom Tromey <tom@tromey.com>
* gdb.texinfo (Configure Options): Document minimum version of
readline.
---
gdb/ChangeLog | 5 +++++
gdb/README | 3 ++-
gdb/doc/ChangeLog | 5 +++++
gdb/doc/gdb.texinfo | 3 ++-
gdb/event-top.c | 3 +++
5 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdb/README b/gdb/README
index 8a91aab2a4c..8883a8a09e3 100644
--- a/gdb/README
+++ b/gdb/README
@@ -439,7 +439,8 @@ more obscure GDB `configure' options are not listed here.
`--with-system-readline'
Use the readline library installed on the host, rather than the
- library supplied as part of GDB.
+ library supplied as part of GDB. Readline 7 or newer is required;
+ this is enforced by the build system.
`--with-system-zlib
Use the zlib library installed on the host, rather than the
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 89b1eda2c17..e384718fc11 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -36897,7 +36897,8 @@ details.
@item --with-system-readline
Use the readline library installed on the host, rather than the
-library supplied as part of @value{GDBN}.
+library supplied as part of @value{GDBN}. Readline 7 or newer is
+required; this is enforced by the build system.
@item --with-system-zlib
Use the zlib library installed on the host, rather than the library
diff --git a/gdb/event-top.c b/gdb/event-top.c
index 2132fb550dc..07cedc42584 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -48,6 +48,9 @@
/* readline defines this. */
#undef savestring
+/* gdb requires readline 7 now. */
+gdb_static_assert (RL_VERSION_MAJOR >= 7);
+
static std::string top_level_prompt ();
/* Signal handlers. */
--
2.17.2
next prev parent reply other threads:[~2019-08-06 20:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 20:43 [PATCH 0/8] Upgrade readline Tom Tromey
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-06 20:43 ` Tom Tromey [this message]
2019-08-07 2:27 ` [PATCH 8/8] Require readline 7 or newer Eli Zaretskii
2019-08-07 14:42 ` Pedro Alves
2019-08-07 22:31 ` Tom Tromey
2019-08-08 2:37 ` Eli Zaretskii
2019-08-08 11:26 ` Pedro Alves
2019-08-08 11:29 ` Pedro Alves
2019-08-08 20:38 ` Tom Tromey
2019-08-07 14:45 ` Pedro Alves
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02 ` [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp Tom de Vries
2019-08-06 20:43 ` [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c Tom Tromey
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29 ` Pedro Alves
2019-08-07 22:03 ` Tom Tromey
2019-08-07 22:16 ` Christian Biesinger via gdb-patches
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-07 3:05 ` [PATCH 0/8] Upgrade readline Kevin Buettner
2019-08-07 13:38 ` Tom Tromey
2019-08-07 13:40 ` Tom Tromey
2019-08-14 10:21 ` Tom de Vries
2019-08-15 13:46 ` Tom Tromey
2019-08-19 16:38 ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31 ` Tom Tromey
2019-08-12 19:46 ` Sergio Durigan Junior
2019-08-12 19:52 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806204334.13441-9-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox