Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp
Date: Tue, 13 Aug 2019 17:02:00 -0000	[thread overview]
Message-ID: <b1dd41f8-020f-cd73-659d-ff27e582d80e@suse.de> (raw)
In-Reply-To: <20190806204334.13441-6-tom@tromey.com>

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

[ was Re: [PATCH 5/8] Fix gdb's selftest.exp after readline import ]

On 06-08-19 22:43, Tom Tromey wrote:
> From: Patrick Palka <patrick@parcs.ath.cx>
> 
> +    gdb_expect {
> +	-re "Program received signal SIGINT.*$gdb_prompt $" {
> +	    pass "$description"
> +	}

I've fixed this regexp to also accept "Thread" instead of "Program".

Thanks,
- Tom


[-- Attachment #2: 0001-gdb-testsuite-Fix-gdb.gdb-selftest.exp-regexp.patch --]
[-- Type: text/x-patch, Size: 1350 bytes --]

[gdb/testsuite] Fix gdb.gdb/selftest.exp regexp

With gdb.gdb/selftest.exp, we get:
...
(xgdb) PASS: gdb.gdb/selftest.exp: send SIGINT signal to child process
^M
Thread 1 "xgdb" received signal SIGINT, Interrupt.^M
0x00007ffff5bf01db in poll () from /lib64/libc.so.6^M
(gdb) FAIL: gdb.gdb/selftest.exp: send ^C to child process again
...

The failure is due to gdb printing 'Thread 1 "xgdb" received signal SIGINT',
but the regexp in the test-case expecting 'Program received signal SIGINT'.

Fix this by updating the regexp, similar to how that is done earlier in the
test-case.

gdb/testsuite/ChangeLog:

2019-08-13  Tom de Vries  <tdevries@suse.de>

	* gdb.gdb/selftest.exp (send ^C to child process again): Accept also
	Thread.

---
 gdb/testsuite/gdb.gdb/selftest.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.gdb/selftest.exp b/gdb/testsuite/gdb.gdb/selftest.exp
index 9651561faf..2f481ec404 100644
--- a/gdb/testsuite/gdb.gdb/selftest.exp
+++ b/gdb/testsuite/gdb.gdb/selftest.exp
@@ -119,7 +119,7 @@ proc test_with_self { } {
     set description "send ^C to child process again"
     send_gdb "\003"
     gdb_expect {
-	-re "Program received signal SIGINT.*$gdb_prompt $" {
+	-re "(Thread .*|Program) received signal SIGINT.*$gdb_prompt $" {
 	    pass "$description"
 	}
 	-re ".*$gdb_prompt $" {

  reply	other threads:[~2019-08-13 17:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 20:43 [PATCH 0/8] Upgrade readline Tom Tromey
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29   ` Pedro Alves
2019-08-07 22:03     ` Tom Tromey
2019-08-07 22:16       ` Christian Biesinger via gdb-patches
2019-08-06 20:43 ` [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c Tom Tromey
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02   ` Tom de Vries [this message]
2019-08-06 20:43 ` [PATCH 8/8] Require readline 7 or newer Tom Tromey
2019-08-07  2:27   ` Eli Zaretskii
2019-08-07 14:42   ` Pedro Alves
2019-08-07 22:31     ` Tom Tromey
2019-08-08  2:37       ` Eli Zaretskii
2019-08-08 11:26       ` Pedro Alves
2019-08-08 11:29       ` Pedro Alves
2019-08-08 20:38         ` Tom Tromey
2019-08-07 14:45   ` Pedro Alves
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-07  3:05 ` [PATCH 0/8] Upgrade readline Kevin Buettner
2019-08-07 13:38   ` Tom Tromey
2019-08-07 13:40   ` Tom Tromey
2019-08-14 10:21     ` Tom de Vries
2019-08-15 13:46       ` Tom Tromey
2019-08-19 16:38         ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31   ` Tom Tromey
2019-08-12 19:46     ` Sergio Durigan Junior
2019-08-12 19:52       ` Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1dd41f8-020f-cd73-659d-ff27e582d80e@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=patrick@parcs.ath.cx \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox