From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37177 invoked by alias); 7 Aug 2019 22:16:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37162 invoked by uid 89); 7 Aug 2019 22:16:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 22:16:30 +0000 Received: by mail-ot1-f68.google.com with SMTP id x21so17347266otq.12 for ; Wed, 07 Aug 2019 15:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JIO9P9mGQW7kHHTFg8ER81dJWm27HGIWGk7fwjEZ5iQ=; b=Nzn8ojD/SDl2FGcNIk93vgQ+yODttXxoT4xTUusUd4WtHK4jwAJ9cT6mWZkH0cJiSN uNRd18fq4/C8jheB1Xr0UxPjwgot1iSizR3XpXtlWZrTuYmXWM9CxVTzdsPLDUj8HxLc vDb2Ltmn1PekfpS1PTo46rdTFtXKudocYryD7KCDMvAwJuunKNA5AsImpZQ7i1TATZch YHA7bZMHvbvPT+kvq1UvdqSleNufLtS4E/ij8rZ9xAXdICJuqVSG+c1Z3YsycasrlZeN qV7LBH1HBGWKaa1PxX3SKLSa72UZF9YJua9H2o1B2g4+qY1m6Wl+upUeUGhQKvGHii1Z +exA== MIME-Version: 1.0 References: <20190806204334.13441-1-tom@tromey.com> <20190806204334.13441-8-tom@tromey.com> <671c7581-6fd8-7ef5-160b-a583e97ba5fe@redhat.com> <871rxwfxah.fsf@tromey.com> In-Reply-To: <871rxwfxah.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 07 Aug 2019 22:16:00 -0000 Message-ID: Subject: Re: [PATCH 7/8] Remove readline hack from gdb_select To: Tom Tromey Cc: Pedro Alves , Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00187.txt.bz2 On Wed, Aug 7, 2019 at 5:03 PM Tom Tromey wrote: > > >>>>> "Pedro" == Pedro Alves writes: > > Pedro> On 8/6/19 9:43 PM, Tom Tromey wrote: > >> As discussed on gdb-patches, this removes the readline hack from the > >> mingw-hdep.c version of gdb_select. It's believed that this is not > >> needed any more. > > Pedro> I may be hard to find the discussion later on. > Pedro> Please add a link to the discussion to the commit log > Pedro> pointing here: > > Pedro> https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html > > Thanks, I did this. > > Also, Christian Biesinger managed to build this branch on Windows and > try it, which is very good news. Yep, it worked fine (up/down arrow worked, Ctrl+R worked). For reference, I compiled in cygwin but with mingw, using: ../configure --disable-binutils --disable-gas --disable-gold --disable-gprof --disable-ld --disable-werror --disable-nls I had to copy libwinpthread-1.dll to out/gdb. Christian