From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 00/11] Demangle minimal symbol names in worker threads
Date: Tue, 08 Oct 2019 02:01:00 -0000 [thread overview]
Message-ID: <CAPTJ0XERCKnhaTHS8n4oyV81_=XMJzRoZhCgd1UsageOWnDEww@mail.gmail.com> (raw)
In-Reply-To: <87h84lqslq.fsf@tromey.com>
On Sun, Oct 6, 2019 at 7:58 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:
>
> Christian> Otherwise, as you mentioned on IRC, it may make sense to land at least
> Christian> the first of my patches together with this one because my patch
> Christian> basically reverts the mutex change in symbol_set_names.
>
> Yeah, I think so. I have yet to read your latest patches, but I
> definitely don't plan to land anything until then. I think we may want
> to move to thread pools as well before moving forward, because that will
> affect the "maint" command that is exposed.
Hm, I'm not sure that needs to be part of the same patchset (since for
now nothing else uses threads). But I did try implementing a thread
pool in https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/cbiesinger/threadpool.
Unfortunately it seems to be a bit slower... I must've implemented it
wrong. My initial impression is that maybe not all threads are used
equally?
(The current version of that threadpool patch does not support
changing the number of threads, so that would have to be changed if
nothing else)
Christian
prev parent reply other threads:[~2019-10-08 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 20:16 Tom Tromey
2019-10-01 20:12 ` [PATCH v4 01/11] Use m4_include, not sinclude in .m4 files Tom Tromey
2019-10-01 20:12 ` [PATCH v4 07/11] Introduce run_on_main_thread Tom Tromey
2019-10-01 20:12 ` [PATCH v4 03/11] Add configure check for std::thread Tom Tromey
2019-10-01 20:12 ` [PATCH v4 11/11] Use run_on_main_thread in gdb.post_event Tom Tromey
2019-10-01 20:12 ` [PATCH v4 05/11] Introduce alternate_signal_stack RAII class Tom Tromey
2019-10-01 20:12 ` [PATCH v4 08/11] Introduce thread-safe way to handle SIGSEGV Tom Tromey
2019-10-01 20:12 ` [PATCH v4 09/11] Demangle minsyms in parallel Tom Tromey
2019-10-01 20:12 ` [PATCH v4 04/11] Add RAII class for blocking gdb signals Tom Tromey
2019-10-01 20:12 ` [PATCH v4 10/11] Add maint set/show max-worker-threads Tom Tromey
2019-10-02 14:54 ` Eli Zaretskii
2019-10-01 20:16 ` [PATCH v4 02/11] Defer minimal symbol name-setting Tom Tromey
2019-10-01 20:16 ` [PATCH v4 06/11] Lock the demangled hash table Tom Tromey
2019-10-06 22:34 ` [PATCH v4 00/11] Demangle minimal symbol names in worker threads Christian Biesinger via gdb-patches
2019-10-07 0:58 ` Tom Tromey
2019-10-08 2:01 ` Christian Biesinger via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XERCKnhaTHS8n4oyV81_=XMJzRoZhCgd1UsageOWnDEww@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox