From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH v4 10/11] Add maint set/show max-worker-threads
Date: Tue, 01 Oct 2019 20:12:00 -0000 [thread overview]
Message-ID: <20191001201227.8519-11-tom@tromey.com> (raw)
In-Reply-To: <20191001201227.8519-1-tom@tromey.com>
This adds maint commands to control the maximum number of worker
threads that gdb can use.
gdb/ChangeLog
2019-10-01 Tom Tromey <tom@tromey.com>
* NEWS: Add entry.
* maint.c (_initialize_maint_cmds): Add "max-worker-threads" maint
commands.
gdb/doc/ChangeLog
2019-10-01 Tom Tromey <tom@tromey.com>
* gdb.texinfo (Maintenance Commands): Document new maint
commands.
---
gdb/ChangeLog | 6 ++++++
gdb/NEWS | 6 ++++++
gdb/doc/ChangeLog | 5 +++++
gdb/doc/gdb.texinfo | 14 ++++++++++++++
gdb/maint.c | 12 ++++++++++++
5 files changed, 43 insertions(+)
diff --git a/gdb/NEWS b/gdb/NEWS
index 779fd91d3a6..7d4988f6cb0 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -122,6 +122,12 @@ set style highlight background COLOR
set style highlight intensity VALUE
Control the styling of highlightings.
+maint set max-worker-threads
+maint show max-worker-threads
+ Control the maximum number of worker threads that can be used by GDB.
+ The default is "unlimited". Currently worker threads are only used when
+ demangling the names of linker symbols.
+
maint set test-settings KIND
maint show test-settings KIND
A set of commands used by the testsuite for exercising the settings
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index f2713c03960..04a40091de4 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -37663,6 +37663,20 @@ with the DWARF frame unwinders enabled.
If DWARF frame unwinders are not supported for a particular target
architecture, then enabling this flag does not cause them to be used.
+
+@kindex maint set max-worker-threads
+@kindex maint show max-worker-threads
+@item maint set max-worker-threads
+@item maint show max-worker-threads
+Control the number of worker threads that may be used by @value{GDBN}.
+On capable hosts, @value{GDBN} may use multiple threads to speed up
+certain CPU-intensive operations, such as demangling symbol names.
+While the number of threads used by @value{GDBN} may vary, this
+command can be used to set an upper bound on this number. The default
+is @code{unlimited}. Note that this only controls worker threads
+started by @value{GDBN} itself; libraries used by @value{GDBN} may
+start threads of their own.
+
@kindex maint set profile
@kindex maint show profile
@cindex profiling GDB
diff --git a/gdb/maint.c b/gdb/maint.c
index ec9f4abb264..8428bea4f92 100644
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -40,6 +40,7 @@
#include "top.h"
#include "maint.h"
#include "gdbsupport/selftest.h"
+#include "gdbsupport/parallel-for.h"
#include "cli/cli-decode.h"
#include "cli/cli-utils.h"
@@ -1312,4 +1313,15 @@ When enabled GDB is profiled."),
show_maintenance_profile_p,
&maintenance_set_cmdlist,
&maintenance_show_cmdlist);
+
+ add_setshow_zuinteger_unlimited_cmd ("max-worker-threads",
+ class_maintenance,
+ &gdb::max_threads, _("\
+Set the maximum number of worker threads GDB can use."), _("\
+Set the maximum number of worker threads GDB can use."), _("\
+GDB may use multiple threads to speed up certain CPU-intensive operations,\n\
+such as demangling symbol names."),
+ NULL, NULL,
+ &maintenance_set_cmdlist,
+ &maintenance_show_cmdlist);
}
--
2.17.2
next prev parent reply other threads:[~2019-10-01 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 20:16 [PATCH v4 00/11] Demangle minimal symbol names in worker threads Tom Tromey
2019-10-01 20:12 ` [PATCH v4 01/11] Use m4_include, not sinclude in .m4 files Tom Tromey
2019-10-01 20:12 ` [PATCH v4 07/11] Introduce run_on_main_thread Tom Tromey
2019-10-01 20:12 ` [PATCH v4 05/11] Introduce alternate_signal_stack RAII class Tom Tromey
2019-10-01 20:12 ` [PATCH v4 03/11] Add configure check for std::thread Tom Tromey
2019-10-01 20:12 ` [PATCH v4 11/11] Use run_on_main_thread in gdb.post_event Tom Tromey
2019-10-01 20:12 ` [PATCH v4 08/11] Introduce thread-safe way to handle SIGSEGV Tom Tromey
2019-10-01 20:12 ` [PATCH v4 09/11] Demangle minsyms in parallel Tom Tromey
2019-10-01 20:12 ` [PATCH v4 04/11] Add RAII class for blocking gdb signals Tom Tromey
2019-10-01 20:12 ` Tom Tromey [this message]
2019-10-02 14:54 ` [PATCH v4 10/11] Add maint set/show max-worker-threads Eli Zaretskii
2019-10-01 20:16 ` [PATCH v4 02/11] Defer minimal symbol name-setting Tom Tromey
2019-10-01 20:16 ` [PATCH v4 06/11] Lock the demangled hash table Tom Tromey
2019-10-06 22:34 ` [PATCH v4 00/11] Demangle minimal symbol names in worker threads Christian Biesinger via gdb-patches
2019-10-07 0:58 ` Tom Tromey
2019-10-08 2:01 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001201227.8519-11-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox