From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 00/11] Demangle minimal symbol names in worker threads
Date: Sun, 06 Oct 2019 22:34:00 -0000 [thread overview]
Message-ID: <CAPTJ0XF84rTW=yH0DLwCTg_8RjpLXHT9havqkZHOz1+0PfXrPQ@mail.gmail.com> (raw)
In-Reply-To: <20191001201227.8519-1-tom@tromey.com>
On Tue, Oct 1, 2019 at 3:16 PM Tom Tromey <tom@tromey.com> wrote:
>
> This is v4 of my patch series to demangle minimal symbol names in
> worker threads.
>
> v3 was here:
>
> https://sourceware.org/ml/gdb-patches/2019-05/msg00669.html
>
> This version addresses all review comments, and fixes a few problems.
> Some significant changes compared to v3:
>
> * Added a patch to switch gdb's m4 files from sinclude to m4_include.
This could probably land separately, it seems independent of the rest.
Otherwise, as you mentioned on IRC, it may make sense to land at least
the first of my patches together with this one because my patch
basically reverts the mutex change in symbol_set_names.
I am really excited about this work on faster symbol loading!
Christian
> * Arranged to block signals that are needed by gdb in new threads.
> E.g. this prevents a SIGCHLD from arriving in the wrong thread.
>
> * Arranged for the demangler threads to call sigaltstack.
>
> * Changed the API of parallel_for_each to make the sigaltstack patch
> work in a non-convoluted way. This also makes it simpler to change
> parallel_for_each to run on top of a thread pool later on, should we
> desire.
>
> * Added a patch to use run_on_main_thread in gdb.post_event, as
> requested.
>
> * Removed the ada_decode patch, as a different version of this has
> landed.
>
> Tested on x86-64 Fedora 28.
>
> Tom
>
>
next prev parent reply other threads:[~2019-10-06 22:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 20:16 Tom Tromey
2019-10-01 20:12 ` [PATCH v4 09/11] Demangle minsyms in parallel Tom Tromey
2019-10-01 20:12 ` [PATCH v4 08/11] Introduce thread-safe way to handle SIGSEGV Tom Tromey
2019-10-01 20:12 ` [PATCH v4 10/11] Add maint set/show max-worker-threads Tom Tromey
2019-10-02 14:54 ` Eli Zaretskii
2019-10-01 20:12 ` [PATCH v4 04/11] Add RAII class for blocking gdb signals Tom Tromey
2019-10-01 20:12 ` [PATCH v4 01/11] Use m4_include, not sinclude in .m4 files Tom Tromey
2019-10-01 20:12 ` [PATCH v4 07/11] Introduce run_on_main_thread Tom Tromey
2019-10-01 20:12 ` [PATCH v4 05/11] Introduce alternate_signal_stack RAII class Tom Tromey
2019-10-01 20:12 ` [PATCH v4 11/11] Use run_on_main_thread in gdb.post_event Tom Tromey
2019-10-01 20:12 ` [PATCH v4 03/11] Add configure check for std::thread Tom Tromey
2019-10-01 20:16 ` [PATCH v4 06/11] Lock the demangled hash table Tom Tromey
2019-10-01 20:16 ` [PATCH v4 02/11] Defer minimal symbol name-setting Tom Tromey
2019-10-06 22:34 ` Christian Biesinger via gdb-patches [this message]
2019-10-07 0:58 ` [PATCH v4 00/11] Demangle minimal symbol names in worker threads Tom Tromey
2019-10-08 2:01 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XF84rTW=yH0DLwCTg_8RjpLXHT9havqkZHOz1+0PfXrPQ@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox