From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32873 invoked by alias); 6 Oct 2019 22:34:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32864 invoked by uid 89); 6 Oct 2019 22:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HTo:U*tom, excited X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 Oct 2019 22:34:41 +0000 Received: by mail-ot1-f68.google.com with SMTP id e11so9461165otl.5 for ; Sun, 06 Oct 2019 15:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5W+PgAaueUyxWTtfy8h28Cuw56KuXNUA7gORmYSHTYI=; b=Jh1P3c2n0Q6g8tA8EH0OcyBQ8oQIKxOq7XXCGh+cf5hBQvH2GxE/iGut3wWhltCxys THs5zkbP6jGtHhjeSpaghTAVul4/xmNp2wPEWplog4Rd3Lfz+RYT1tafJ4sgO0mO5rVh tI/oFQMrwRjulYoSn7hhqB3qvEk01v9NLyCdpRRpm6vpNkZ5fTJ5P3refbQDG6D3ezna rXsByh4wqQId2Kb9PmiMCYguaQZiAXVldlWHxi7q7r9pIa3v5UVmt7HY/1Pfdrf3hmdp +vx3XQKSyUC/GI4atyehjRVl99HClV/VHCAXYXjmfaAD+YfwxACdrb//JjAeYNy3DRig GiaA== MIME-Version: 1.0 References: <20191001201227.8519-1-tom@tromey.com> In-Reply-To: <20191001201227.8519-1-tom@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sun, 06 Oct 2019 22:34:00 -0000 Message-ID: Subject: Re: [PATCH v4 00/11] Demangle minimal symbol names in worker threads To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00178.txt.bz2 On Tue, Oct 1, 2019 at 3:16 PM Tom Tromey wrote: > > This is v4 of my patch series to demangle minimal symbol names in > worker threads. > > v3 was here: > > https://sourceware.org/ml/gdb-patches/2019-05/msg00669.html > > This version addresses all review comments, and fixes a few problems. > Some significant changes compared to v3: > > * Added a patch to switch gdb's m4 files from sinclude to m4_include. This could probably land separately, it seems independent of the rest. Otherwise, as you mentioned on IRC, it may make sense to land at least the first of my patches together with this one because my patch basically reverts the mutex change in symbol_set_names. I am really excited about this work on faster symbol loading! Christian > * Arranged to block signals that are needed by gdb in new threads. > E.g. this prevents a SIGCHLD from arriving in the wrong thread. > > * Arranged for the demangler threads to call sigaltstack. > > * Changed the API of parallel_for_each to make the sigaltstack patch > work in a non-convoluted way. This also makes it simpler to change > parallel_for_each to run on top of a thread pool later on, should we > desire. > > * Added a patch to use run_on_main_thread in gdb.post_event, as > requested. > > * Removed the ada_decode patch, as a different version of this has > landed. > > Tested on x86-64 Fedora 28. > > Tom > >