Re: [PATCH v4 00/11] Demangle minimal symbol names in worker threads

Christian Biesinger via gdb-patches
2019-10-08T02:01:13Z

On Sun, Oct 6, 2019 at 7:58 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:
>
> Christian> Otherwise, as you mentioned on IRC, it may make sense to land at least
> Christian> the first of my patches together with this one because my patch
> Christian> basically reverts the mutex change in symbol_set_names.
>
> Yeah, I think so. I have yet to read your latest patches, but I
> definitely don't plan to land anything until then. I think we may want
> to move to thread pools as well before moving forward, because that will
> affect the "maint" command that is exposed.

Hm, I'm not sure that needs to be part of the same patchset (since for
now nothing else uses threads). But I did try implementing a thread
pool in https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/cbiesinger/threadpool.
Unfortunately it seems to be a bit slower... I must've implemented it
wrong. My initial impression is that maybe not all threads are used
equally?

(The current version of that threadpool patch does not support
changing the number of threads, so that would have to be changed if
nothing else)

Christian