From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10131 invoked by alias); 8 Oct 2019 02:01:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9573 invoked by uid 89); 8 Oct 2019 02:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=binutilsgdbgit, UD:binutils-gdb.git, binutils-gdb.git X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2019 02:00:20 +0000 Received: by mail-ot1-f66.google.com with SMTP id 60so12798450otu.0 for ; Mon, 07 Oct 2019 19:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n5rhsfhVfmq7tmEjqBSMW5QYAr+jVFKQxaqTetz9aPs=; b=JywTAiXDeGrA1NK6cTjPC1JOFKjt/259eVCCYbwghY9IZrz/FJxZj7ji65T+Y/0aGy L6FyRLWhvPnxjGELIbZvUZqmLxVxd4CiB1yTCm6sCI+0WauLzlJ2OgDRrfpvLPxGKPqI dP3dtPep6f+3VoQaMlOLLL3l/xM/VPVZ9944EqJiIVorUtNn0E4NsAwITDQkM7FyeU2r 38VjSN7ZJ9ltmjivPl3t57YuaIs4otxVEr7TiYaUL2xg+8nhnKRMc7laNJK1yJGRX3hn R6BWQzDQsFMhpZ9vqiZ2hBqLib1I0ODPheuN0G8ahRtry7pVkfvbQ3jdgSVtd3Xi0hz5 +jkQ== MIME-Version: 1.0 References: <20191001201227.8519-1-tom@tromey.com> <87h84lqslq.fsf@tromey.com> In-Reply-To: <87h84lqslq.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Tue, 08 Oct 2019 02:01:00 -0000 Message-ID: Subject: Re: [PATCH v4 00/11] Demangle minimal symbol names in worker threads To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00216.txt.bz2 On Sun, Oct 6, 2019 at 7:58 PM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger writes: > > Christian> Otherwise, as you mentioned on IRC, it may make sense to land at least > Christian> the first of my patches together with this one because my patch > Christian> basically reverts the mutex change in symbol_set_names. > > Yeah, I think so. I have yet to read your latest patches, but I > definitely don't plan to land anything until then. I think we may want > to move to thread pools as well before moving forward, because that will > affect the "maint" command that is exposed. Hm, I'm not sure that needs to be part of the same patchset (since for now nothing else uses threads). But I did try implementing a thread pool in https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/cbiesinger/threadpool. Unfortunately it seems to be a bit slower... I must've implemented it wrong. My initial impression is that maybe not all threads are used equally? (The current version of that threadpool patch does not support changing the number of threads, so that would have to be changed if nothing else) Christian