* [PING] Bad Indentation in remote.c: Someone please correct this.
@ 2011-09-07 9:44 Abhijit Halder
2011-09-07 9:46 ` Abhijit Halder
2011-09-07 9:59 ` Pedro Alves
0 siblings, 2 replies; 6+ messages in thread
From: Abhijit Halder @ 2011-09-07 9:44 UTC (permalink / raw)
To: gdb-patches
---------- Forwarded message ----------
From: Abhijit Halder <abhijit.k.halder@gmail.com>
Date: Sat, Sep 3, 2011 at 3:02 PM
Subject: Bad Indentation
To: gdb-patches@sourceware.org
Hi,
I've found the following indentation problem. Can someone plz correct the same.
#cvs diff gdb/remote.c
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.461
diff -r1.461 remote.c
4883c4883
< }
---
> }
Though this is not breaking anything (not a defect in that sense), but
code walk through sometime become difficult.
Thanks,
Abhijit Halder
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Bad Indentation in remote.c: Someone please correct this.
2011-09-07 9:44 [PING] Bad Indentation in remote.c: Someone please correct this Abhijit Halder
@ 2011-09-07 9:46 ` Abhijit Halder
2011-09-07 9:59 ` Pedro Alves
1 sibling, 0 replies; 6+ messages in thread
From: Abhijit Halder @ 2011-09-07 9:46 UTC (permalink / raw)
To: gdb-patches
On Wed, Sep 7, 2011 at 3:02 PM, Abhijit Halder
<abhijit.k.halder@gmail.com> wrote:
> ---------- Forwarded message ----------
> From: Abhijit Halder <abhijit.k.halder@gmail.com>
> Date: Sat, Sep 3, 2011 at 3:02 PM
> Subject: Bad Indentation
> To: gdb-patches@sourceware.org
>
>
> Hi,
>
> I've found the following indentation problem. Can someone plz correct the same.
>
> #cvs diff gdb/remote.c
>
> Index: gdb/remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.461
> diff -r1.461 remote.c
> 4883c4883
> < }
> ---
>> }
> Though this is not breaking anything (not a defect in that sense), but
> code walk through sometime become difficult.
>
> Thanks,
> Abhijit Halder
>
The actual fix should be:
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.461
diff -r1.461 remote.c
4882,4883c4882,4883
< gdb_flush (gdb_stdtarg);
< }
---
> gdb_flush (gdb_stdtarg);
> }
Thanks,
Abhijit Halder
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Bad Indentation in remote.c: Someone please correct this.
2011-09-07 9:44 [PING] Bad Indentation in remote.c: Someone please correct this Abhijit Halder
2011-09-07 9:46 ` Abhijit Halder
@ 2011-09-07 9:59 ` Pedro Alves
2011-09-07 10:08 ` Abhijit Halder
1 sibling, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2011-09-07 9:59 UTC (permalink / raw)
To: gdb-patches; +Cc: Abhijit Halder
On Wednesday 07 September 2011 10:32:51, Abhijit Halder wrote:
> #cvs diff gdb/remote.c
>
> Index: gdb/remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.461
> diff -r1.461 remote.c
> 4883c4883
> < }
> ---
> > }
plain diff output is unreadable by mere mortals. Use "cvs diff -up".
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Bad Indentation in remote.c: Someone please correct this.
2011-09-07 9:59 ` Pedro Alves
@ 2011-09-07 10:08 ` Abhijit Halder
2011-09-07 10:38 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Abhijit Halder @ 2011-09-07 10:08 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
On Wed, Sep 7, 2011 at 3:23 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 07 September 2011 10:32:51, Abhijit Halder wrote:
>
>> #cvs diff gdb/remote.c
>>
>> Index: gdb/remote.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/remote.c,v
>> retrieving revision 1.461
>> diff -r1.461 remote.c
>> 4883c4883
>> < }
>> ---
>> > }
>
> plain diff output is unreadable by mere mortals. Use "cvs diff -up".
>
> --
> Pedro Alves
>
Okay. Here it is:
# cvs diff -up gdb/remote.c
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.461
diff -u -p -r1.461 remote.c
--- gdb/remote.c 14 Aug 2011 13:03:12 -0000 1.461
+++ gdb/remote.c 7 Sep 2011 10:00:39 -0000
@@ -4879,8 +4879,8 @@ remote_console_output (char *msg)
tb[1] = 0;
fputs_unfiltered (tb, gdb_stdtarg);
}
- gdb_flush (gdb_stdtarg);
- }
+ gdb_flush (gdb_stdtarg);
+}
typedef struct cached_reg
{
Regards,
Abhijit Halder
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Bad Indentation in remote.c: Someone please correct this.
2011-09-07 10:08 ` Abhijit Halder
@ 2011-09-07 10:38 ` Pedro Alves
2011-09-07 10:44 ` Abhijit Halder
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2011-09-07 10:38 UTC (permalink / raw)
To: Abhijit Halder; +Cc: gdb-patches
On Wednesday 07 September 2011 11:02:35, Abhijit Halder wrote:
> On Wed, Sep 7, 2011 at 3:23 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> > On Wednesday 07 September 2011 10:32:51, Abhijit Halder wrote:
> >
> >> #cvs diff gdb/remote.c
> >>
> >> Index: gdb/remote.c
> >> ===================================================================
> >> RCS file: /cvs/src/src/gdb/remote.c,v
> >> retrieving revision 1.461
> >> diff -r1.461 remote.c
> >> 4883c4883
> >> < }
> >> ---
> >> > }
> >
> > plain diff output is unreadable by mere mortals. Use "cvs diff -up".
> >
> > --
> > Pedro Alves
> >
>
> Okay. Here it is:
>
Applied, thanks. Please send a ChangeLog entry next time.
--
Pedro Alves
2011-09-07 Abhijit Halder <abhijit.k.halder@gmail.com>
* remote.c (remote_console_output): Reindent.
---
gdb/remote.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: src/gdb/remote.c
===================================================================
--- src.orig/gdb/remote.c 2011-08-26 12:58:48.000000000 +0100
+++ src/gdb/remote.c 2011-09-07 11:29:14.357975075 +0100
@@ -4879,8 +4879,8 @@ remote_console_output (char *msg)
tb[1] = 0;
fputs_unfiltered (tb, gdb_stdtarg);
}
- gdb_flush (gdb_stdtarg);
- }
+ gdb_flush (gdb_stdtarg);
+}
typedef struct cached_reg
{
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PING] Bad Indentation in remote.c: Someone please correct this.
2011-09-07 10:38 ` Pedro Alves
@ 2011-09-07 10:44 ` Abhijit Halder
0 siblings, 0 replies; 6+ messages in thread
From: Abhijit Halder @ 2011-09-07 10:44 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
On Wed, Sep 7, 2011 at 4:05 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 07 September 2011 11:02:35, Abhijit Halder wrote:
>> On Wed, Sep 7, 2011 at 3:23 PM, Pedro Alves <pedro@codesourcery.com> wrote:
>> > On Wednesday 07 September 2011 10:32:51, Abhijit Halder wrote:
>> >
>> >> #cvs diff gdb/remote.c
>> >>
>> >> Index: gdb/remote.c
>> >> ===================================================================
>> >> RCS file: /cvs/src/src/gdb/remote.c,v
>> >> retrieving revision 1.461
>> >> diff -r1.461 remote.c
>> >> 4883c4883
>> >> < }
>> >> ---
>> >> > }
>> >
>> > plain diff output is unreadable by mere mortals. Use "cvs diff -up".
>> >
>> > --
>> > Pedro Alves
>> >
>>
>> Okay. Here it is:
>>
>
> Applied, thanks. Please send a ChangeLog entry next time.
>
> --
> Pedro Alves
>
> 2011-09-07 Abhijit Halder <abhijit.k.halder@gmail.com>
>
> * remote.c (remote_console_output): Reindent.
>
> ---
> gdb/remote.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: src/gdb/remote.c
> ===================================================================
> --- src.orig/gdb/remote.c 2011-08-26 12:58:48.000000000 +0100
> +++ src/gdb/remote.c 2011-09-07 11:29:14.357975075 +0100
> @@ -4879,8 +4879,8 @@ remote_console_output (char *msg)
> tb[1] = 0;
> fputs_unfiltered (tb, gdb_stdtarg);
> }
> - gdb_flush (gdb_stdtarg);
> - }
> + gdb_flush (gdb_stdtarg);
> +}
>
> typedef struct cached_reg
> {
>
Sure.
Thanks,
Abhijit Halder
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-07 10:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-07 9:44 [PING] Bad Indentation in remote.c: Someone please correct this Abhijit Halder
2011-09-07 9:46 ` Abhijit Halder
2011-09-07 9:59 ` Pedro Alves
2011-09-07 10:08 ` Abhijit Halder
2011-09-07 10:38 ` Pedro Alves
2011-09-07 10:44 ` Abhijit Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox