From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25874 invoked by alias); 7 Sep 2011 09:44:26 -0000 Received: (qmail 25866 invoked by uid 22791); 7 Sep 2011 09:44:25 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 09:44:11 +0000 Received: by wwe32 with SMTP id 32so6158431wwe.12 for ; Wed, 07 Sep 2011 02:44:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.169.74 with SMTP id m52mr1320426wel.33.1315388650511; Wed, 07 Sep 2011 02:44:10 -0700 (PDT) Received: by 10.216.22.75 with HTTP; Wed, 7 Sep 2011 02:44:10 -0700 (PDT) In-Reply-To: References: Date: Wed, 07 Sep 2011 09:46:00 -0000 Message-ID: Subject: Re: [PING] Bad Indentation in remote.c: Someone please correct this. From: Abhijit Halder To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00107.txt.bz2 On Wed, Sep 7, 2011 at 3:02 PM, Abhijit Halder wrote: > ---------- Forwarded message ---------- > From: Abhijit Halder > Date: Sat, Sep 3, 2011 at 3:02 PM > Subject: Bad Indentation > To: gdb-patches@sourceware.org > > > Hi, > > I've found the following indentation problem. Can someone plz correct the= same. > > #cvs diff gdb/remote.c > > Index: gdb/remote.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/remote.c,v > retrieving revision 1.461 > diff -r1.461 remote.c > 4883c4883 > < =A0 } > --- >> } > Though this is not breaking anything (not a defect in that sense), but > code walk through sometime become difficult. > > Thanks, > Abhijit Halder > The actual fix should be: Index: gdb/remote.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.461 diff -r1.461 remote.c 4882,4883c4882,4883 < gdb_flush (gdb_stdtarg); < } --- > gdb_flush (gdb_stdtarg); > } Thanks, Abhijit Halder