Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Abhijit Halder <abhijit.k.halder@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: [PING] Bad Indentation in remote.c: Someone please correct this.
Date: Wed, 07 Sep 2011 09:46:00 -0000	[thread overview]
Message-ID: <CAOhZP9yF__g5PM5hgF305RMKGCcacRUU8sn9f5a+NBw+r=UA1A@mail.gmail.com> (raw)
In-Reply-To: <CAOhZP9x3-Ba2d88ibN-Cxczgbu_wJHeXfByviVoADg4FjDUXEQ@mail.gmail.com>

On Wed, Sep 7, 2011 at 3:02 PM, Abhijit Halder
<abhijit.k.halder@gmail.com> wrote:
> ---------- Forwarded message ----------
> From: Abhijit Halder <abhijit.k.halder@gmail.com>
> Date: Sat, Sep 3, 2011 at 3:02 PM
> Subject: Bad Indentation
> To: gdb-patches@sourceware.org
>
>
> Hi,
>
> I've found the following indentation problem. Can someone plz correct the same.
>
> #cvs diff gdb/remote.c
>
> Index: gdb/remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.461
> diff -r1.461 remote.c
> 4883c4883
> <   }
> ---
>> }
> Though this is not breaking anything (not a defect in that sense), but
> code walk through sometime become difficult.
>
> Thanks,
> Abhijit Halder
>

The actual fix should be:

Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.461
diff -r1.461 remote.c
4882,4883c4882,4883
<     gdb_flush (gdb_stdtarg);
<   }
---
>   gdb_flush (gdb_stdtarg);
> }

Thanks,
Abhijit Halder


  reply	other threads:[~2011-09-07  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07  9:44 Abhijit Halder
2011-09-07  9:46 ` Abhijit Halder [this message]
2011-09-07  9:59 ` Pedro Alves
2011-09-07 10:08   ` Abhijit Halder
2011-09-07 10:38     ` Pedro Alves
2011-09-07 10:44       ` Abhijit Halder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOhZP9yF__g5PM5hgF305RMKGCcacRUU8sn9f5a+NBw+r=UA1A@mail.gmail.com' \
    --to=abhijit.k.halder@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox